Skip to content

When dragging a material over a surface in the scene view, the undo stack is spammed with undo states #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nukeandbeans opened this issue Apr 26, 2022 · 1 comment · Fixed by #349
Closed

When dragging a material over a surface in the scene view, the undo stack is spammed with undo states #355

nukeandbeans opened this issue Apr 26, 2022 · 1 comment · Fixed by #349
Assignees
@nukeandbeans
Labels
Bug Fix available

Comments

@nukeandbeans
Copy link
Collaborator

Bug is located here:

realtime-CSG-for-unity/Plugins/Editor/Scripts/View/DragAndDrop/SceneDragTool.Materials.cs

Line 564 in a3ccdb6

if (!modified)

Where the check is inverted from what it should be.

(!modified)
{
    // etc...
}

should be

(modified)
{
    // etc...
}

This will be fixed with other fixes in PR #349
@nukeandbeans nukeandbeans self-assigned this Apr 26, 2022
@nukeandbeans nukeandbeans mentioned this issue Apr 26, 2022
Merged
nukeandbeans pushed a commit to nukeandbeans/realtime-CSG-for-unity that referenced this issue Apr 26, 2022
@kerfuffles
Fix LogicalError#355
a0cce58
@Janooba
Copy link
Contributor

Janooba commented Jun 13, 2022

Confirmed fixed in #349 using 2019.4.31f1

Zallist pushed a commit to Zallist/realtime-CSG-for-unity that referenced this issue Sep 23, 2022
@kerfuffles @Zallist
Fix LogicalError#355
609f280
FriskTheFallenHuman pushed a commit to FriskTheFallenHuman/RealtimeCSG that referenced this issue Jan 30, 2023
@kerfuffles @FriskTheFallenHuman
MSC Bug Fixes (LogicalError#349)
4a969ef 
Co-authored-by: Zallist <[email protected]>
Co-authored-by: Gawi <[email protected]>

* Update Window.mat and Window.png to support proper transparency and specularity.
* Fixes LogicalError#323
* Fixes LogicalError#355
* Fixes LogicalError#350
* Fixes LogicalError#319
* Fixes LogicalError#320
* Fixes LogicalError#354
* Fixes LogicalError#356
* Fixes LogicalError#365
* Fixes LogicalError#366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nukeandbeans nukeandbeans

Labels
Bug Fix available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MSC Bug Fixes nukeandbeans/realtime-CSG-for-unity
2 participants
@nukeandbeans @Janooba