Skip to content

Surface Selection stops working if the cursor leaves boundary of the brush / 2021.3.0f1 #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexjhetherington opened this issue Apr 22, 2022 · 2 comments · Fixed by #349
Closed

Surface Selection stops working if the cursor leaves boundary of the brush / 2021.3.0f1 #354

alexjhetherington opened this issue Apr 22, 2022 · 2 comments · Fixed by #349
Assignees
@nukeandbeans
Labels
Bug Fix available

Comments

@alexjhetherington
Copy link

alexjhetherington commented Apr 22, 2022 •
edited
Loading

Reproducing 2021.3.0f1 personal. Not reproducing on 2019.

Does not cause any large usability issues but makes it feel "slow"

Video:
https://user-images.githubusercontent.com/36995359/164752942-6b691a49-eaee-4daf-bf7d-72adfb5f4fe2.mov

Saved asset folder:
Assets.zip
@nukeandbeans
Copy link
Collaborator

nukeandbeans commented Apr 26, 2022 •
edited
Loading

Poking around with this, it appears that a repaint event isn't triggered properly for hover selection previews, causing the selection previews to appear sluggish or unresponsive.

I am able to fix this with a rough hack, but said hack causes high CPU and GPU use.

@nukeandbeans nukeandbeans self-assigned this Apr 26, 2022
nukeandbeans pushed a commit to nukeandbeans/realtime-CSG-for-unity that referenced this issue Jun 10, 2022
@kerfuffles
Fixes for LogicalError#354 and LogicalError#356, update Window.mat an…
b2ccf73 
…d Window.png to use proper transparency and shininess
@nukeandbeans nukeandbeans mentioned this issue Jun 10, 2022
Merged
@Janooba
Copy link
Contributor

Janooba commented Jun 13, 2022

Not sure I fully understand the repro steps as the video link is broken now, but I can't seem to reproduce the issue with #349 so I'm happy saying it's fixed.
Tested on 2019.4.31f1 and 2020.3.35f1

Zallist pushed a commit to Zallist/realtime-CSG-for-unity that referenced this issue Sep 23, 2022
@kerfuffles @Zallist
Fixes for LogicalError#354 and LogicalError#356, update Window.mat an…
182301f 
…d Window.png to use proper transparency and shininess
FriskTheFallenHuman pushed a commit to FriskTheFallenHuman/RealtimeCSG that referenced this issue Jan 30, 2023
@kerfuffles @FriskTheFallenHuman
MSC Bug Fixes (LogicalError#349)
4a969ef 
Co-authored-by: Zallist <[email protected]>
Co-authored-by: Gawi <[email protected]>

* Update Window.mat and Window.png to support proper transparency and specularity.
* Fixes LogicalError#323
* Fixes LogicalError#355
* Fixes LogicalError#350
* Fixes LogicalError#319
* Fixes LogicalError#320
* Fixes LogicalError#354
* Fixes LogicalError#356
* Fixes LogicalError#365
* Fixes LogicalError#366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nukeandbeans nukeandbeans

Labels
Bug Fix available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MSC Bug Fixes nukeandbeans/realtime-CSG-for-unity
3 participants
@nukeandbeans @Janooba @alexjhetherington