Encoder: add logging, move docs to README.md #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdp7
approved these changes
Nov 17, 2017
|
Thanks @dplanella |
pdp7
added a commit
that referenced
this pull request
Nov 19, 2017
Release 1.0.8: ============== Fixes: Issue #196: cache board type to avoid poor performance Issue #192: fix PocketBeagle PWM pin typo Issue #191: turn off RotaryEncoder's debug output by default Issue #188: GPIO is extremely slow (20ms to toggle) Issue #186: problems with UART shortlog: David Planella (12): Copy Encoder module comments to README.md Formatted Encoder README in markdown Fixed Encoder README formatting Removed QEP instructions from Encoder module Fixes to Encoder README Updated Encoder README Encoder README: added info on dedicated overlays Encoder README: updated info on pre-requisites Encoder README update Encoder README update Add logging support, turn off unconditional debug output Encoder: remove unused logging code Drew Fustini (3): Merge pull request #195 from dplanella/master Fix PocketBeagle PWM pin typo (#192) cache board type to avoid poor performance (#196) Signed-off-by: Drew Fustini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logging support to the Encoder module and turn off unconditional debug output. To use, add the following statements to any application that uses the module:
To see more verbose output,
logging.DEBUGcan be used. Refer to the Python logging module documentation for more info.The module was also lightly cleaned up by moving the instructions to set up QEP to a separate README.md file for an easier read and maintenance.