Skip to content

Typo in pin ID #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fivdi opened this issue Nov 15, 2017 · 3 comments
Closed

Typo in pin ID #192

fivdi opened this issue Nov 15, 2017 · 3 comments
Assignees
Labels

Comments

@fivdi
Copy link

fivdi commented Nov 15, 2017

The following line of code from commin.c defines ehrpwm0 channel 1 as being available on P1_13 on a PocketBeagle.

  { "ehrpwm0", 1, 1, 1, "ehrpwm.0:1", "EHRPWM0B", "48300000", "48300200", "P1_13"},

However, P1_13 is reserved for USB1-ID. It looks like there is a typo here and P1_13 should be P1_33.

  { "ehrpwm0", 1, 1, 1, "ehrpwm.0:1", "EHRPWM0B", "48300000", "48300200", "P1_33"},
@pdp7
Copy link
Collaborator

pdp7 commented Nov 15, 2017

@fivdi thanks for opening this issue.

@RobertCNelson could you take a look?

@pdp7 pdp7 self-assigned this Nov 15, 2017
@RobertCNelson
Copy link
Contributor

Confirmed p1_13 is the usb pin, looks like a day finger write by me.. traveling so I can only asked the change.

Regards

@pdp7 pdp7 added the bug label Nov 17, 2017
pdp7 added a commit that referenced this issue Nov 17, 2017
ehrpwm0 channel 1 is  P1_33 on a the PocketBeagle

Signed-off-by: Drew Fustini <[email protected]>
@pdp7
Copy link
Collaborator

pdp7 commented Nov 17, 2017

@fivdi @RobertCNelson Thanks, I've pushed b328cdd to fix the typo

@pdp7 pdp7 closed this as completed Nov 17, 2017
pdp7 added a commit that referenced this issue Nov 19, 2017
Release 1.0.8:
==============
Fixes:
  Issue #196: cache board type to avoid poor performance
  Issue #192: fix PocketBeagle PWM pin typo
  Issue #191: turn off RotaryEncoder's debug output by default
  Issue #188: GPIO is extremely slow (20ms to toggle)
  Issue #186: problems with UART

shortlog:

David Planella (12):
  Copy Encoder module comments to README.md
  Formatted Encoder README in markdown
  Fixed Encoder README formatting
  Removed QEP instructions from Encoder module
  Fixes to Encoder README
  Updated Encoder README
  Encoder README: added info on dedicated overlays
  Encoder README: updated info on pre-requisites
  Encoder README update
  Encoder README update
  Add logging support, turn off unconditional debug output
  Encoder: remove unused logging code

Drew Fustini (3):
  Merge pull request #195 from dplanella/master
  Fix PocketBeagle PWM pin typo (#192)
  cache board type to avoid poor performance (#196)

Signed-off-by: Drew Fustini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants