VIDEO-11239 Add Krisp Noise Cancellation #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manjeshbhargav
changed the title
manjeshbhargav
requested review from
PikaJoyce
and removed request for
timmydoza
PikaJoyce
previously approved these changes
Sep 27, 2022
PikaJoyce
reviewed
Nov 18, 2022
There was a problem hiding this comment.
Awesome work @manjeshbhargav!
Left one small comment but otherwise it LGTM!
Comment on lines
+43
to
+46
| noiseCancellationOptions: { | ||
| sdkAssetsPath: '/noisecancellation', | ||
| vendor: 'krisp', | ||
| }, |
There was a problem hiding this comment.
It seems like we re-use this multiple times in this file. Can we store this as a variable once and reuse that?
There was a problem hiding this comment.
@PikaJoyce I'll do that in a separate PR. Now, I'm focused on getting this out.
PikaJoyce
approved these changes
Nov 18, 2022
|
Is there a possibility to disable this feature? I'm getting errors in the Firefox console, and am unable to join a room with version 0.9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR adds Krisp to the Ahoy app. If Krisp is installed, users can enable and disable noise cancellation by clicking the switch button on the Device Selection Screen before joining the room, and any time during the call by accessing Audio and Video settings.
Burndown
Before review
npm testBefore merge