Skip to content

Commit 0dc7f37

Browse files
VIDEO-11239 Get current unit tests to pass.
1 parent f6c940c commit 0dc7f37

File tree

6 files changed

+20
-6
lines changed

6 files changed

+20
-6
lines changed

package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/MenuBar/Menu/Menu.test.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@ import useLocalVideoToggle from '../../../hooks/useLocalVideoToggle/useLocalVide
2020
jest.mock('../../../hooks/useFlipCameraToggle/useFlipCameraToggle');
2121
jest.mock('@material-ui/core/useMediaQuery');
2222
jest.mock('../../../state');
23-
jest.mock('../../../hooks/useVideoContext/useVideoContext', () => () => ({ room: { sid: 'mockRoomSid' } }));
23+
jest.mock('../../../hooks/useVideoContext/useVideoContext', () => () => ({
24+
localTracks: [],
25+
room: { sid: 'mockRoomSid' },
26+
}));
2427
jest.mock('../../../hooks/useIsRecording/useIsRecording');
2528
jest.mock('../../../hooks/useChatContext/useChatContext');
2629
jest.mock('../../../hooks/useLocalVideoToggle/useLocalVideoToggle');

src/components/PreJoinScreens/DeviceSelectionScreen/DeviceSelectionScreen.test.tsx

+4
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ mockUseVideoContext.mockImplementation(() => ({
2525
connect: mockConnect,
2626
isAcquiringLocalTracks: false,
2727
isConnecting: false,
28+
localTracks: [],
2829
}));
2930

3031
describe('the DeviceSelectionScreen component', () => {
@@ -38,6 +39,7 @@ describe('the DeviceSelectionScreen component', () => {
3839
connect: mockConnect,
3940
isAcquiringLocalTracks: false,
4041
isConnecting: true,
42+
localTracks: [],
4143
}));
4244

4345
const wrapper = shallow(<DeviceSelectionScreen name="test name" roomName="test room name" setStep={() => {}} />);
@@ -60,6 +62,7 @@ describe('the DeviceSelectionScreen component', () => {
6062
connect: mockConnect,
6163
isAcquiringLocalTracks: true,
6264
isConnecting: false,
65+
localTracks: [],
6366
}));
6467

6568
const wrapper = shallow(<DeviceSelectionScreen name="test name" roomName="test room name" setStep={() => {}} />);
@@ -82,6 +85,7 @@ describe('the DeviceSelectionScreen component', () => {
8285
connect: mockConnect,
8386
isAcquiringLocalTracks: false,
8487
isConnecting: false,
88+
localTracks: [],
8589
}));
8690
mockUseAppState.mockImplementationOnce(() => ({ getToken: mockGetToken, isFetching: true }));
8791
const wrapper = shallow(<DeviceSelectionScreen name="test name" roomName="test room name" setStep={() => {}} />);

src/components/VideoProvider/index.test.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ describe('the VideoProvider component', () => {
6161
onError: expect.any(Function),
6262
connect: expect.any(Function),
6363
getLocalVideoTrack: expect.any(Function),
64-
getLocalAudioTrack: expect.any(Function),
6564
removeLocalVideoTrack: expect.any(Function),
6665
isAcquiringLocalTracks: true,
6766
toggleScreenShare: expect.any(Function),

src/components/VideoProvider/useLocalTracks/useLocalTracks.test.tsx

+6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
import { act, renderHook } from '@testing-library/react-hooks';
22
import { getDeviceInfo, isPermissionDenied } from '../../../utils';
33
import { SELECTED_AUDIO_INPUT_KEY, SELECTED_VIDEO_INPUT_KEY, DEFAULT_VIDEO_CONSTRAINTS } from '../../../constants';
4+
import { useAppState } from '../../../state';
45
import useLocalTracks from './useLocalTracks';
56
import Video from 'twilio-video';
67

8+
jest.mock('../../../state');
79
jest.mock('../../../utils');
10+
811
const mockGetDeviceInfo = getDeviceInfo as jest.Mock<any>;
912
const mockIsPermissionDenied = isPermissionDenied as jest.Mock<Promise<boolean>>;
13+
const mockUseAppState = useAppState as jest.Mock<any>;
14+
15+
mockUseAppState.mockImplementation(() => ({ setIsKrispEnabled: false }));
1016

1117
describe('the useLocalTracks hook', () => {
1218
beforeEach(() => {

src/components/VideoProvider/useLocalTracks/useLocalTracks.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,11 @@ export default function useLocalTracks() {
103103
(hasSelectedAudioDevice
104104
? {
105105
deviceId: { exact: selectedAudioDeviceId! },
106-
noiseCancellationOptions: isKrispInstalled ? noiseCancellationOptions : {},
106+
...(isKrispInstalled ? { noiseCancellationOptions } : {}),
107107
}
108-
: { noiseCancellationOptions: isKrispInstalled ? noiseCancellationOptions : {} }),
108+
: isKrispInstalled
109+
? { noiseCancellationOptions }
110+
: true),
109111
};
110112

111113
return Video.createLocalTracks(localTrackConstraints)

0 commit comments

Comments
 (0)