-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rollup of 4 pull requests #135133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rollup of 4 pull requests #135133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jubilee <[email protected]>
Searching "fma" in the Rust documentation returns results for `intrinsics::fma*`, but does not point to the user-facing `mul_add`. Add aliases for `fma*` and the IEEE operation name `fusedMultiplyAdd`. Add the IEEE name to `sqrt` as well, `squareRoot`.
Co-authored-by: Jubilee <[email protected]>
…ingjubilee add m68k-unknown-none-elf target r? `@workingjubilee` The existing `m68k-unknown-linux-gnu` target builds `std` by default, requires atomics, and has a base cpu with an fpu. A smaller/more embedded target is desirable both to have a baseline target for the ISA, as well to make debugging easier for working on the llvm backend. Currently this target is using the `M68010` as the minimum CPU due, but as missing features are merged into the `M68k` llvm backend I am hoping to lower this further. I have been able to build very small crates using a toolchain built against this target (together with a later version of `object`) using the configuration described in the target platform-support documentation, although getting anything of substantial complexity to build quickly hits errors in the llvm backend
…trieb Add doc aliases for `libm` and IEEE names Searching "fma" in the Rust documentation returns results for `intrinsics::fma*`, but does not point to the user-facing `mul_add`. Add aliases for `fma*` and the IEEE operation name `fusedMultiplyAdd`. Add the IEEE name to `sqrt` as well, `squareRoot`.
triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide` Probably should also create a dev-guide reviewer pool for this repo 🤔 r? `@Kobzol`
dev guide ping group and set adhoc reviewers to compiler r? `@jieyouxu` `@Kobzol` I added you both to the `cc` list since you're both also on the list of owners for `src/doc/rustc-dev-guide`
@bors r+ rollup=never p=4 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 5, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#135085 (add m68k-unknown-none-elf target) - rust-lang#135111 (Add doc aliases for `libm` and IEEE names) - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`) - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler) r? `@ghost` `@rustbot` modify labels: rollup
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry (msvc) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#135085 (add m68k-unknown-none-elf target) - rust-lang#135111 (Add doc aliases for `libm` and IEEE names) - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`) - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler) r? `@ghost` `@rustbot` modify labels: rollup
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2025
Rollup of 4 pull requests Successful merges: - rust-lang#135085 (add m68k-unknown-none-elf target) - rust-lang#135111 (Add doc aliases for `libm` and IEEE names) - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`) - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler) r? `@ghost` `@rustbot` modify labels: rollup try-job: dist-aarch64-apple
Hm, maybe would've hit llvm assertions if they were enabled in the dist job? Not sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
CI-spurious-fail-msvc
CI spurious failure: target env msvc
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
libm
and IEEE names #135111 (Add doc aliases forlibm
and IEEE names)src/doc/rustc-dev-guide
changes withA-rustc-dev-guide
#135129 (triagebot: labelsrc/doc/rustc-dev-guide
changes withA-rustc-dev-guide
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
try-job: dist-aarch64-apple