dev guide ping group and set adhoc reviewers to compiler #135132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-meta
|
|
BoxyUwU
commented
Jan 5, 2025
triagebot.toml
Outdated
| @@ -1208,7 +1212,7 @@ project-exploit-mitigations = [ | |||
| "/src/doc/nomicon" = ["@ehuss"] | |||
| "/src/doc/reference" = ["@ehuss"] | |||
| "/src/doc/rust-by-example" = ["@ehuss"] | |||
| "/src/doc/rustc-dev-guide" = ["@kobzol", "@jieyouxu"] | |||
| "/src/doc/rustc-dev-guide" = ["@kobzol", "@jieyouxu", "@BoxyUwU"] | |||
There was a problem hiding this comment.
I also added myself here but I wonder if we should actually be just assigning compiler since in most cases it will be compiler PRs that happen to also touch the dev guide
There was a problem hiding this comment.
I don't think we should ping the entire compiler team on every change to the dev guide, I personally do not want to be pinged
There was a problem hiding this comment.
oh wait you mean assignment. yeah assigning compiler makes sense
There was a problem hiding this comment.
I'm actually just going to go ahead and do that, let me know what you think. With the ping group we'll all get notified whenever anyone touches the subtree anyway so I don't know if there's a point in explicitly maintaining a separate list here from compiler when these PRs are going to want a compiler reviewer anyway 🤷♀️
BoxyUwU
changed the title
BoxyUwU
force-pushed
the
rdg_ping_group
branch
from
f9f882e to
2cc114c
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 5, 2025
dev guide ping group and set adhoc reviewers to compiler r? `@jieyouxu` `@Kobzol` I added you both to the `cc` list since you're both also on the list of owners for `src/doc/rustc-dev-guide`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 5, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#135085 (add m68k-unknown-none-elf target) - rust-lang#135111 (Add doc aliases for `libm` and IEEE names) - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`) - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#135085 (add m68k-unknown-none-elf target) - rust-lang#135111 (Add doc aliases for `libm` and IEEE names) - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`) - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2025
Rollup of 4 pull requests Successful merges: - rust-lang#135085 (add m68k-unknown-none-elf target) - rust-lang#135111 (Add doc aliases for `libm` and IEEE names) - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`) - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler) r? `@ghost` `@rustbot` modify labels: rollup try-job: dist-aarch64-apple
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#135111 (Add doc aliases for `libm` and IEEE names) - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`) - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler) - rust-lang#135145 (Mention `unnameable_types` in `unreachable_pub` documentation.) - rust-lang#135147 (A few borrowck tweaks to improve 2024 edition migration lints) - rust-lang#135150 (move footnote to ordinary comment) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2025
Rollup merge of rust-lang#135132 - BoxyUwU:rdg_ping_group, r=jieyouxu dev guide ping group and set adhoc reviewers to compiler r? ``@jieyouxu`` ``@Kobzol`` I added you both to the `cc` list since you're both also on the list of owners for `src/doc/rustc-dev-guide`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jieyouxu @Kobzol
I added you both to the
cclist since you're both also on the list of owners forsrc/doc/rustc-dev-guide