[4.x] Fix deprecation warnings for react >= 15.5.0 #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is fine. I guess my only concern is this: does |
|
If you look at the travis build for 1e749f2, prior of the Edit: The build url -> https://travis-ci.org/reactjs/react-redux/builds/220278187 |
|
Yea it works as it’s completely standalone. |
|
Pushed as 4.4.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #663, I backported the patch for new deprecation warnings introduced by react 15.5.0
react-addons-test-utilsseems to have been moved toreact-dom/test-utilsonly onreact >= 15.5.0, in order to use it we'll have to bump the devDependencies to at least that version.As it's used only during test phase, I don't think it will be that much of a problem, what do you think?