-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix deprecation warnings for react >= 15.5.0 #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this work if someone is still targeting React 14? |
It should. PropTypes were not wildly modified since then. |
It should work. But I'm not sure if putting it in dependencies would be better. |
Yes, lets change this to use dependencies instead. |
42efcf7
to
6954a01
Compare
Ok :) I moved it from devDependencies to dependencies, and drop the line for peers. |
We probably don't need Yarn lock? Seems unrelated to this PR. |
6954a01
to
5d874b4
Compare
👍 yarn.lock modifications removed |
5d874b4
to
40b589f
Compare
Yes, you do. yarn.lock files are updated with every PR that modifies the dependencies. It's the same for other systems that use lock files (e.g., rubygems) |
Thanks, @Calyhre. I've got some follow-on fixes for the tests and to put the lock file back. I'll add those after I merge this in. Thanks! |
Oops, pardon the brainfart. I don't really understand why I said that 😛 |
@Calyhre Would you like to also send a PR to backport this to 4.x? |
Just pushed out 5.0.4 with this. Thanks! |
old react version will warning |
Yes, we’re discussing this in #669. |
I released |
Migrate
React.PropTypes
toPropTypes
from theprop-types
package, regarding the latestreact
version -> https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes