Skip to content

Bump @nextcloud/vue from 5.4.0 to 7.0.1 #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 17, 2022

Bumps @nextcloud/vue from 5.4.0 to 7.0.1.

Release notes

Sourced from @​nextcloud/vue's releases.

v7.0.1

v7.0.1 (2022-10-14)

Full Changelog

🐛 Fixed bugs

🚀 Enhancements

  • Migrate to use :deep selector instead of deprecated ::v-deep #3348 (susnux)

v7.0.0

💥 Breaking changes

  • This component library release requires Nextcloud 25 or later
  • We changed the container layout to adapt to the design changes with Nextcloud 25
  • The body is no longer the main scroll area but instead the app content - Please do careful testing of your user interface, especially in regards to the following components and scroll behaviour: - NcContent - NcAppNavigation - NcAppContent - NcAppSidebar
  • Properties and slot names of NcEmptyContent changed. Also, everything outside a slot is ignored now
  • Inside NcActions, only Vue components are considered as children

Migration guide

  • Scroll listeners need to be adapted to watch for the scroll on the NcAppContent container instead of the main document
  • If you are using sticky headers in your app you might need to adjust the css top property as the app content container is now the scrollable element. For any contained sticky that had a header height top spacing before you should be able to set that to 0
  • Make sure that everything in NcEmptyContent is in one of the supported slots
  • Make sure that NcActions contain only Vue components. If they contain plain HTML, move this into a separate Vue component

🚀 Enhancements

🐛 Fixed bugs

... (truncated)

Changelog

Sourced from @​nextcloud/vue's changelog.

v7.0.1 (2022-10-14)

Full Changelog

🐛 Fixed bugs

🚀 Enhancements

  • Migrate to use :deep selector instead of deprecated ::v-deep #3348 (susnux)

v7.0.0 - 2022-10-12

Full Changelog

💥 Breaking changes

  • This component library release requires Nextcloud 25 or later
  • We changed the container layout to adapt to the design changes with Nextcloud 25
  • The body is no longer the main scroll area but instead the app content
    • Please do careful testing of your user interface, especially in regards to the following components and scroll behaviour:
      • NcContent
      • NcAppNavigation
      • NcAppContent
      • NcAppSidebar
  • Properties and slot names of NcEmptyContent changed. Also, everything outside a slot is ignored now
  • Inside NcActions, only Vue components are considered as children

Migration guide

  • Scroll listeners need to be adapted to watch for the scroll on the NcAppContent container instead of the main document
  • If you are using sticky headers in your app you might need to adjust the css top property as the app content container is now the scrollable element. For any contained sticky that had a header height top spacing before you should be able to set that to 0
  • Make sure that everything in NcEmptyContent is in one of the supported slots
  • Make sure that NcActions contain only Vue components. If they contain plain HTML, move this into a separate Vue component

🚀 Enhancements

... (truncated)

Commits
  • 6e4546d Merge pull request #3364 from nextcloud/release/7.0.1
  • 0783d99 Update CHANGELOG.md
  • d34b0c8 Update CHANGELOG.md
  • f7a95c5 7.0.1
  • 1e8f74a Merge pull request #3348 from nextcloud/fix/deep-warning
  • e44924e Update @nextcloud/stylelint-config to 2.3.0 to allow :deep pseudo-class
  • 25ddef4 Merge pull request #3357 from nextcloud/translations_l10n-messages-pot--maste...
  • 95e4bee Merge pull request #3362 from nextcloud/dependabot/npm_and_yarn/vue-template-...
  • f8f392d Bump vue-template-compiler from 2.7.12 to 2.7.13
  • 7e3800d Merge pull request #3347 from nextcloud/feature/add-nc-focus-trap
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 17, 2022
@github-actions
Copy link

Unit Test Results

     27 files       27 suites   6m 11s ⏱️
   476 tests    476 ✔️ 0 💤 0
4 284 runs  4 283 ✔️ 1 💤 0

Results for commit 77896e0.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #1255 (9dbbd53) into master (d7fb96d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1255   +/-   ##
=======================================
  Coverage   78.97%   78.97%           
=======================================
  Files          86       86           
  Lines        2297     2297           
=======================================
  Hits         1814     1814           
  Misses        483      483           
Flag Coverage Δ
integration 21.59% <ø> (ø)
migration 4.04% <ø> (ø)
unittests 57.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christianlupus
Copy link
Collaborator

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nextcloud/vue-7.0.1 branch from 77896e0 to 715f948 Compare October 31, 2022 16:21
@github-actions
Copy link

github-actions bot commented Oct 31, 2022

Test Results

     21 files     952 suites   4m 48s ⏱️
   495 tests    495 ✔️ 0 💤 0
3 465 runs  3 464 ✔️ 1 💤 0

Results for commit 9dbbd53.

♻️ This comment has been updated with latest results.

@christianlupus
Copy link
Collaborator

@dependabot rebase

Bumps [@nextcloud/vue](https://github.com./nextcloud/nextcloud-vue) from 5.4.0 to 7.0.1.
- [Release notes](https://github.com./nextcloud/nextcloud-vue/releases)
- [Changelog](https://github.com./nextcloud/nextcloud-vue/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-vue@v5.4.0...v7.0.1)

---
updated-dependencies:
- dependency-name: "@nextcloud/vue"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nextcloud/vue-7.0.1 branch from 715f948 to 685e098 Compare November 1, 2022 08:40
@christianlupus
Copy link
Collaborator

Closes #1208

@christianlupus christianlupus linked an issue Nov 1, 2022 that may be closed by this pull request
@christianlupus christianlupus merged commit ae78b8d into master Nov 1, 2022
@christianlupus christianlupus deleted the dependabot/npm_and_yarn/nextcloud/vue-7.0.1 branch November 1, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for NC version 25
1 participant