Skip to content

Bump @nextcloud/vue from 5.4.0 to 7.0.0 #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 13, 2022

Bumps @nextcloud/vue from 5.4.0 to 7.0.0.

Release notes

Sourced from @​nextcloud/vue's releases.

v7.0.0

💥 Breaking changes

  • This component library release requires Nextcloud 25 or later
  • We changed the container layout to adapt to the design changes with Nextcloud 25
  • The body is no longer the main scroll area but instead the app content - Please do careful testing of your user interface, especially in regards to the following components and scroll behaviour: - NcContent - NcAppNavigation - NcAppContent - NcAppSidebar
  • Properties and slot names of NcEmptyContent changed. Also, everything outside a slot is ignored now
  • Inside NcActions, only Vue components are considered as children

Migration guide

  • Scroll listeners need to be adapted to watch for the scroll on the NcAppContent container instead of the main document
  • If you are using sticky headers in your app you might need to adjust the css top property as the app content container is now the scrollable element. For any contained sticky that had a header height top spacing before you should be able to set that to 0
  • Make sure that everything in NcEmptyContent is in one of the supported slots
  • Make sure that NcActions contain only Vue components. If they contain plain HTML, move this into a separate Vue component

🚀 Enhancements

🐛 Fixed bugs

... (truncated)

Changelog

Sourced from @​nextcloud/vue's changelog.

v7.0.0 - 2022-10-12

💥 Breaking changes

  • This component library release requires Nextcloud 25 or later
  • We changed the container layout to adapt to the design changes with Nextcloud 25
  • The body is no longer the main scroll area but instead the app content
    • Please do careful testing of your user interface, especially in regards to the following components and scroll behaviour:
      • NcContent
      • NcAppNavigation
      • NcAppContent
      • NcAppSidebar
  • Properties and slot names of NcEmptyContent changed. Also, everything outside a slot is ignored now
  • Inside NcActions, only Vue components are considered as children

Migration guide

  • Scroll listeners need to be adapted to watch for the scroll on the NcAppContent container instead of the main document
  • If you are using sticky headers in your app you might need to adjust the css top property as the app content container is now the scrollable element. For any contained sticky that had a header height top spacing before you should be able to set that to 0
  • Make sure that everything in NcEmptyContent is in one of the supported slots
  • Make sure that NcActions contain only Vue components. If they contain plain HTML, move this into a separate Vue component

🚀 Enhancements

🐛 Fixed bugs

... (truncated)

Commits
  • 225533c Merge pull request #3355 from nextcloud/v7.0.0
  • 4698eea Mention NcEmptyContent and NcActions breaking changes in release notes
  • 2f3f40e v7.0.0
  • 8722992 Merge pull request #3307 from nextcloud/fix/maxcontrast-text-appnavigation
  • 182fc7b Fix maxcontrast text contrast on blurred background
  • f70ddbd Merge pull request #3341 from nextcloud/dependabot/npm_and_yarn/jest-29.1.2
  • 6cfd8c9 Merge pull request #3343 from nextcloud/fix/emoji-focus
  • a3bc44e Fix emoji picker and Popover no-Auto-Focus
  • 58d6276 Merge pull request #3349 from nextcloud/dependabot/npm_and_yarn/sass-loader-1...
  • a9f2443 Merge pull request #3339 from nextcloud/dependabot/npm_and_yarn/nextcloud/axi...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 13, 2022
@github-actions
Copy link

github-actions bot commented Oct 13, 2022

Unit Test Results

     27 files       27 suites   5m 46s ⏱️
   476 tests    476 ✔️ 0 💤 0
4 284 runs  4 283 ✔️ 1 💤 0

Results for commit b73d2ee.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #1249 (b73d2ee) into master (4c91eac) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1249   +/-   ##
=======================================
  Coverage   78.90%   78.90%           
=======================================
  Files          85       85           
  Lines        2252     2252           
=======================================
  Hits         1777     1777           
  Misses        475      475           
Flag Coverage Δ
integration 21.75% <ø> (ø)
migration 4.12% <ø> (ø)
unittests 57.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christianlupus
Copy link
Collaborator

This is a big change and needs dedicated addressing. This means we have to create multiple branches of code due to the incompatibility with NC prior to 25!

Bumps [@nextcloud/vue](https://github.com./nextcloud/nextcloud-vue) from 5.4.0 to 7.0.0.
- [Release notes](https://github.com./nextcloud/nextcloud-vue/releases)
- [Changelog](https://github.com./nextcloud/nextcloud-vue/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-vue@v5.4.0...v7.0.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/vue"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nextcloud/vue-7.0.0 branch from c87aa77 to b73d2ee Compare October 14, 2022 14:29
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 17, 2022

Superseded by #1255.

@dependabot dependabot bot closed this Oct 17, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/nextcloud/vue-7.0.0 branch October 17, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant