Enable Rollback Support of VAC with Infeasible Errors #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunnylovestiramisu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
sunnylovestiramisu
force-pushed
the
fixVacBeforeGA
branch
from
0a9dc85 to
20411cf
Compare
sunnylovestiramisu
force-pushed
the
fixVacBeforeGA
branch
from
20411cf to
5cc5fe8
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
gnufied
reviewed
Mar 31, 2025
| @@ -65,6 +65,24 @@ func (ctrl *modifyController) modify(pvc *v1.PersistentVolumeClaim, pv *v1.Persi | |||
| } | |||
| return ctrl.controllerModifyVolumeWithTarget(pvc, pv, vac, pvcSpecVacName) | |||
| } | |||
| } else if pvcSpecVacName != nil && curVacName != nil && pvc.Status.ModifyVolumeStatus != nil && *pvcSpecVacName == *curVacName { | |||
There was a problem hiding this comment.
Can pvcSpecVacName ever be nil in this code path? I think that, this code is way harder to read and understand because all the used if and else conditions need to be simplified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
ControllerModifyVolume should allow rollback if a modification ends in infeasible state.
Which issue(s) this PR fixes:
Fixes #482 , kubernetes/kubernetes#130597
Special notes for your reviewer:
Does this PR introduce a user-facing change?: