Skip to content

VolumeAttributesClass update should support recover from failure #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xing-yang opened this issue Mar 5, 2025 · 3 comments · May be fixed by #487
Open

VolumeAttributesClass update should support recover from failure #482

xing-yang opened this issue Mar 5, 2025 · 3 comments · May be fixed by #487

Comments

@xing-yang
Copy link
Contributor

xing-yang commented Mar 5, 2025

I opened an issue in k/k to track this: kubernetes/kubernetes#130597
The fix will probably mainly happen in csi-resizer.

@xing-yang
Copy link
Contributor Author

@carlory
Copy link
Member

carlory commented Mar 11, 2025

related to: #483

@sunnylovestiramisu
Copy link
Contributor

The suggested fix is:

When spec.vac == status.curvac but targetvac != status.curvac and the volume has a condition of isInfeasibleError(InvalidArgument, OutOfRange and NotFound), trigger modify volume(rollback) again and set targetvac=status.curvac, clear errors and conditions.

If the rollback operation fails, it will go back to the logic of "spec.vac == status.curvac but targetvac != status.curvac" as above, and retry modify volume with different rate based on the if the error is infeasible or final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants