Simplify emoji rendering (#34048) #34049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like most of our custom styles around the .emoji class are useless and we can just make them render like any other text. Rendering should now match GitHub. Fixes: go-gitea#34019 Also see go-gitea#11541 and go-gitea#12317 for some context. I think browser emoji rendering has improved in recent years so these hacks are no longer needed. --------- Co-authored-by: wxiaoguang <[email protected]>
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
Mar 28, 2025
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Mar 28, 2025
GiteaBot
added
lgtm/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #34048 by @silverwind
It seems like most of our custom styles around the .emoji class are useless and we can just make them render like any other text. Rendering should now match GitHub.
Fixes: #34019
Also see #11541 and #12317 for some context. I think browser emoji rendering has improved in recent years so these hacks are no longer needed.
Gitea:
GitHub: