-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
The emoji and header in the markdown are not aligned on the same line #34019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Which OS is this on? Windows? Could be related to Windows' emoji font. |
Windows |
I can reproduce on MacOS as well. The emoji renders bigger on Gitea compared to GitHub: https://gitea.com/silverwind/symlink-test#-test ![]() https://github.com./silverwind/symlink-test#-test ![]() |
@hiifong Removing |
|
Looks good. So we definitely should remove that font size. Maybe even remove the whole |
It seems like most of our custom styles around the .emoji class are useless and we can just make them render like any other text. Fixes: go-gitea#34019
Yeah, it looks a lot better. |
It seems like most of our custom styles around the .emoji class are useless and we can just make them render like any other text. Rendering should now match GitHub. Fixes: #34019 Also see #11541 and #12317 for some context. I think browser emoji rendering has improved in recent years so these hacks are no longer needed. --------- Co-authored-by: wxiaoguang <[email protected]>
It seems like most of our custom styles around the .emoji class are useless and we can just make them render like any other text. Rendering should now match GitHub. Fixes: go-gitea#34019 Also see go-gitea#11541 and go-gitea#12317 for some context. I think browser emoji rendering has improved in recent years so these hacks are no longer needed. --------- Co-authored-by: wxiaoguang <[email protected]>
Description
The emoji and header in the markdown are not aligned on the same line. The alignment is a bit vague, but I think it may be vertical alignment or baseline alignment. Maybe we can set
vertical-align: baseline;
set
vertical-align: baseline;
after:Gitea Version
gitea.com
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
gitea.com
Database
None
The text was updated successfully, but these errors were encountered: