Skip to content

FIO-10006: Radio values not displayed with render mode html #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/components/radio/Radio.js
Original file line number Diff line number Diff line change
Expand Up @@ -179,14 +179,21 @@ export default class RadioComponent extends ListComponent {
});
}

convertValues(values) {
if (this.options.renderMode === 'html' && this.type === 'radio') {
return values.map(x => ({ ...x, value: this.convertByDataType(x.value) }))
}
return values
}

render() {
if (!this.optionsLoaded) {
return super.render(this.renderTemplate('loader'));
}
return super.render(this.renderTemplate('radio', {
input: this.inputInfo,
inline: this.component.inline,
values: this.component.dataSrc === 'values' ? this.component.values : this.loadedOptions,
values: this.component.dataSrc === 'values' ? this.convertValues(this.component.values) : this.loadedOptions,
value: this.dataValue,
row: this.row,
}));
Expand Down Expand Up @@ -472,15 +479,14 @@ export default class RadioComponent extends ListComponent {
* @param {*} value - The value to normalize
* @returns {*} - Returns the normalized value
*/
normalizeValue(value) {
convertByDataType(value) {
const dataType = this.component.dataType || 'auto';
if (value === this.emptyValue) {
return value;
}

switch (dataType) {
case 'auto':

if (!isNaN(parseFloat(value)) && isFinite(value) && _.toString(value) === Number(value).toString()) {
value = +value;
}
Expand All @@ -507,15 +513,21 @@ export default class RadioComponent extends ListComponent {
break;
}

if (this.isSelectURL && this.templateData && this.templateData[value]) {
return value;
}

normalizeValue(value) {
const valueConverted = this.convertByDataType(value)

if (this.isSelectURL && this.templateData && this.templateData[valueConverted]) {
const submission = this.root.submission;
if (!submission.metadata.selectData) {
submission.metadata.selectData = {};
}

_.set(submission.metadata.selectData, this.path, this.templateData[value]);
_.set(submission.metadata.selectData, this.path, this.templateData[valueConverted]);
}

return super.normalizeValue(value);
return super.normalizeValue(valueConverted);
}
}
22 changes: 21 additions & 1 deletion test/unit/Radio.unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ import {
comp9,
comp10,
comp11,
comp13
comp13,
comp14
} from './fixtures/radio';
import { fastCloneDeep } from '@formio/core';
import { wait } from '../util';

describe('Radio Component', () => {
it('Should build a radio component', () => {
Expand Down Expand Up @@ -607,4 +609,22 @@ describe('Radio Component', () => {
})
.catch(done);
});

it("Should display result for radio submission with form='html' and dataType='number'", async function () {
const element = document.createElement('div');
const form = await Formio.createForm(
element,
comp14,
{
readOnly: true,
renderMode: 'html'
}
);
const el = form.element.querySelector('[ref="value"]');
assert.equal(el.innerHTML.trim(), '');
await form.setSubmission({ data: { radio: 2, submit: true } });
await wait(200);
const elNext = form.element.querySelector('[ref="value"]');
assert.equal(elNext.innerHTML.trim(), 'B');
});
});
36 changes: 36 additions & 0 deletions test/unit/fixtures/radio/comp14.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
export default {
type: "form",
name: "selectr",
path: "selectr",
components: [
{
label: "Radio",
optionsLabelPosition: "right",
inline: false,
tableView: false,
defaultValue: true,
values: [
{
label: "A",
value: "1",
shortcut: ""
},
{
label: "B",
value: "2",
shortcut: ""
},
{
label: "C",
value: "3",
shortcut: ""
},
],
dataType: "number",
validateWhenHidden: false,
key: "radio",
type: "radio",
input: true
},
]
}
3 changes: 2 additions & 1 deletion test/unit/fixtures/radio/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ import comp10 from './comp10';
import comp11 from './comp11';
import comp12 from './comp12';
import comp13 from './comp13';
export { comp1, comp2, comp3, comp4, comp5, comp6, comp7, comp8, comp9, comp10, comp11, comp12, comp13 };
import comp14 from './comp14';
export { comp1, comp2, comp3, comp4, comp5, comp6, comp7, comp8, comp9, comp10, comp11, comp12, comp13, comp14};
Loading