Skip to content

FIO-10006: Radio values not displayed with render mode html #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yauheni-formio
Copy link

@yauheni-formio yauheni-formio commented Apr 24, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-10006

Description

Fix bug related to values of the radio component are not displayed when the renderMode: "HTML", dataType number/not chosen, and radio values are numbers. The problem is when we change the dataType to "number" for example, the value in the submit goes through the normalizeValue function and becomes a number. The values ​​of this.component.dataSrc are strings, so in the html.ejs.js template we have a strict comparison of values, so the bug occurred. My solution involves normalizing all values ​​in this.component.dataSrc in accordance with the passed dataType.

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

I added unit test.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant