Officially onboard AMD Genoa

.buildkite/common.py

@@ -19,6 +19,7 @@
     "m5n.metal",  # Intel Cascade Lake
     "m6i.metal",  # Intel Icelake
     "m6a.metal",  # AMD Milan
+    "m7a.metal-48xl",  # AMD Genoa
     "m6g.metal",  # Graviton2
     "m7g.metal",  # Graviton3
 ]

.buildkite/pipeline_cpu_template.py

@@ -26,7 +26,13 @@ class BkStep(str, Enum):
             "tools/devtool -y test --no-build -- -m nonci -n4 --dist worksteal integration_tests/functional/test_cpu_features_x86_64.py -k 'test_cpu_rdmsr' "
         ],
         BkStep.LABEL: "📖 rdmsr",
-        "instances": ["c5n.metal", "m5n.metal", "m6a.metal", "m6i.metal"],
+        "instances": [
+            "c5n.metal",
+            "m5n.metal",
+            "m6i.metal",
+            "m6a.metal",
+            "m7a.metal-48xl",
+        ],
     },
     "fingerprint": {
         BkStep.COMMAND: [
@@ -59,7 +65,13 @@ class BkStep(str, Enum):
             "c5n.metal": ["m5n.metal", "m6i.metal"],
             "m6i.metal": ["m5n.metal", "c5n.metal"],
         },
-        "instances": ["c5n.metal", "m5n.metal", "m6i.metal", "m6a.metal"],
+        "instances": [
+            "c5n.metal",
+            "m5n.metal",
+            "m6i.metal",
+            "m6a.metal",
+            "m7a.metal-48xl",
+        ],
     },
 }
 

.buildkite/pipeline_cross.py

@@ -18,7 +18,13 @@
     per_instance = pipeline.per_instance.copy()
     per_instance.pop("instances")
     per_instance.pop("platforms")
-    instances_x86_64 = ["c5n.metal", "m5n.metal", "m6i.metal", "m6a.metal"]
+    instances_x86_64 = [
+        "c5n.metal",
+        "m5n.metal",
+        "m6i.metal",
+        "m6a.metal",
+        "m7a.metal-48xl",
+    ]
     instances_aarch64 = ["m7g.metal"]
     commands = [
         "./tools/devtool -y test --no-build -- -m nonci -n4 integration_tests/functional/test_snapshot_phase1.py",

CHANGELOG.md

@@ -43,6 +43,8 @@ and this project adheres to
   provides the appropriate ELF Note to indicate that PVH boot mode is supported.
   Linux kernels newer than 5.0 compiled with `CONFIG_PVH=y` set this ELF Note,
   as do FreeBSD kernels.
+- [#5088](https://github.com./firecracker-microvm/firecracker/pull/5088): Added
+  AMD Genoa as a supported and tested platform for Firecracker.
 
 ### Changed
 

README.md

@@ -130,14 +130,15 @@ The **API endpoint** can be used to:
 
 We test all combinations of:
 
-| Instance  | Host OS & Kernel | Guest Rootfs | Guest Kernel |
-| :-------- | :--------------- | :----------- | :----------- |
-| c5n.metal | al2 linux_5.10   | ubuntu 24.04 | linux_5.10   |
-| m5n.metal | al2023 linux_6.1 |              | linux_6.1    |
-| m6i.metal |                  |              |              |
-| m6a.metal |                  |              |              |
-| m6g.metal |                  |              |              |
-| m7g.metal |                  |              |              |
+| Instance       | Host OS & Kernel | Guest Rootfs | Guest Kernel |
+| :------------- | :--------------- | :----------- | :----------- |
+| c5n.metal      | al2 linux_5.10   | ubuntu 24.04 | linux_5.10   |
+| m5n.metal      | al2023 linux_6.1 |              | linux_6.1    |
+| m6i.metal      |                  |              |              |
+| m6a.metal      |                  |              |              |
+| m7a.metal-48xl |                  |              |              |
+| m6g.metal      |                  |              |              |
+| m7g.metal      |                  |              |              |
 
 ## Known issues and Limitations
 

tests/data/msr/msr_list_T2A_AMD_GENOA_5.10host_5.10guest.csv

@@ -0,0 +1,298 @@
+MSR_ADDR,VALUE
+0,0x0
+0x1,0x0
+0x10,0x86e8ca1e
+0x11,0x24a1008
+0x12,0x24a2001
+0x17,0x0
+0x1b,0xfee00d00
+0x2a,0x0
+0x2c,0x1000000
+0x34,0x0
+0x3b,0x0
+0x48,0x0
+0x8b,0x1000065
+0xc1,0x0
+0xc2,0x0
+0xcd,0x3
+0xce,0x80000000
+0xfe,0x508
+0x11e,0xbe702111
+0x140,0x0
+0x174,0x10
+0x175,0xfffffe0000003000
+0x176,0xffffffff81a01510
+0x179,0x20
+0x17a,0x0
+0x186,0x0
+0x187,0x0
+0x198,0x400000003e8
+0x199,0x0
+0x1a0,0x1
+0x1d9,0x0
+0x1db,0x0
+0x1dc,0x0
+0x1dd,0x0
+0x1de,0x0
+0x1fc,0x0
+0x200,0x0
+0x201,0x0
+0x202,0x0
+0x203,0x0
+0x204,0x0
+0x205,0x0
+0x206,0x0
+0x207,0x0
+0x208,0x0
+0x209,0x0
+0x20a,0x0
+0x20b,0x0
+0x20c,0x0
+0x20d,0x0
+0x20e,0x0
+0x20f,0x0
+0x250,0x0
+0x258,0x0
+0x259,0x0
+0x268,0x0
+0x269,0x0
+0x26a,0x0
+0x26b,0x0
+0x26c,0x0
+0x26d,0x0
+0x26e,0x0
+0x26f,0x0
+0x277,0x7040600070406
+0x2ff,0x0
+0x400,0x0
+0x401,0x0
+0x402,0x0
+0x403,0x0
+0x404,0x0
+0x405,0x0
+0x406,0x0
+0x407,0x0
+0x408,0x0
+0x409,0x0
+0x40a,0x0
+0x40b,0x0
+0x40c,0x0
+0x40d,0x0
+0x40e,0x0
+0x40f,0x0
+0x410,0x0
+0x411,0x0
+0x412,0x0
+0x413,0x0
+0x414,0x0
+0x415,0x0
+0x416,0x0
+0x417,0x0
+0x418,0x0
+0x419,0x0
+0x41a,0x0
+0x41b,0x0
+0x41c,0x0
+0x41d,0x0
+0x41e,0x0
+0x41f,0x0
+0x420,0x0
+0x421,0x0
+0x422,0x0
+0x423,0x0
+0x424,0x0
+0x425,0x0
+0x426,0x0
+0x427,0x0
+0x428,0x0
+0x429,0x0
+0x42a,0x0
+0x42b,0x0
+0x42c,0x0
+0x42d,0x0
+0x42e,0x0
+0x42f,0x0
+0x430,0x0
+0x431,0x0
+0x432,0x0
+0x433,0x0
+0x434,0x0
+0x435,0x0
+0x436,0x0
+0x437,0x0
+0x438,0x0
+0x439,0x0
+0x43a,0x0
+0x43b,0x0
+0x43c,0x0
+0x43d,0x0
+0x43e,0x0
+0x43f,0x0
+0x440,0x0
+0x441,0x0
+0x442,0x0
+0x443,0x0
+0x444,0x0
+0x445,0x0
+0x446,0x0
+0x447,0x0
+0x448,0x0
+0x449,0x0
+0x44a,0x0
+0x44b,0x0
+0x44c,0x0
+0x44d,0x0
+0x44e,0x0
+0x44f,0x0
+0x450,0x0
+0x451,0x0
+0x452,0x0
+0x453,0x0
+0x454,0x0
+0x455,0x0
+0x456,0x0
+0x457,0x0
+0x458,0x0
+0x459,0x0
+0x45a,0x0
+0x45b,0x0
+0x45c,0x0
+0x45d,0x0
+0x45e,0x0
+0x45f,0x0
+0x460,0x0
+0x461,0x0
+0x462,0x0
+0x463,0x0
+0x464,0x0
+0x465,0x0
+0x466,0x0
+0x467,0x0
+0x468,0x0
+0x469,0x0
+0x46a,0x0
+0x46b,0x0
+0x46c,0x0
+0x46d,0x0
+0x46e,0x0
+0x46f,0x0
+0x470,0x0
+0x471,0x0
+0x472,0x0
+0x473,0x0
+0x474,0x0
+0x475,0x0
+0x476,0x0
+0x477,0x0
+0x478,0x0
+0x479,0x0
+0x47a,0x0
+0x47b,0x0
+0x47c,0x0
+0x47d,0x0
+0x47e,0x0
+0x47f,0x0
+0x606,0x0
+0x611,0x0
+0x619,0x0
+0x639,0x0
+0x641,0x0
+0x6e0,0x150b49126
+0x802,0x0
+0x803,0x50014
+0x808,0x10
+0x80a,0x10
+0x80d,0x1
+0x80f,0x1ff
+0x810,0x0
+0x811,0x0
+0x812,0x0
+0x813,0x0
+0x814,0x0
+0x815,0x0
+0x816,0x0
+0x817,0x0
+0x818,0x0
+0x819,0x0
+0x81a,0x0
+0x81b,0x0
+0x81c,0x0
+0x81d,0x0
+0x81e,0x0
+0x81f,0x0
+0x820,0x0
+0x821,0x0
+0x822,0x0
+0x823,0x0
+0x824,0x0
+0x825,0x0
+0x826,0x0
+0x827,0x0
+0x828,0x0
+0x830,0x0
+0x832,0x400ec
+0x833,0x10000
+0x834,0x400
+0x835,0x10700
+0x836,0x400
+0x837,0xfe
+0x838,0x0
+0x839,0x0
+0x83e,0x0
+0xc0000080,0xd01
+0xc0000081,0x23001000000000
+0xc0000082,0xffffffff81a00080
+0xc0000083,0xffffffff81a015c0
+0xc0000084,0x47700
+0xc0000100,0x7fbe30c03740
+0xc0000101,0xffff88803ec00000
+0xc0000102,0x0
+0xc0000103,0x0
+0xc0010000,0x0
+0xc0010001,0x0
+0xc0010002,0x0
+0xc0010003,0x0
+0xc0010004,0x0
+0xc0010005,0x0
+0xc0010006,0x0
+0xc0010007,0x0
+0xc0010010,0x0
+0xc0010015,0x0
+0xc001001b,0x20000000
+0xc001001f,0x0
+0xc0010055,0x0
+0xc0010058,0x0
+0xc0010112,0x0
+0xc0010113,0x0
+0xc0010114,0x0
+0xc0010117,0x0
+0xc001011f,0x0
+0xc0010131,0x0
+0xc0010140,0x4
+0xc0010141,0x0
+0xc0010200,0x0
+0xc0010201,0x0
+0xc0010202,0x0
+0xc0010203,0x0
+0xc0010204,0x0
+0xc0010205,0x0
+0xc0010206,0x0
+0xc0010207,0x0
+0xc0010208,0x0
+0xc0010209,0x0
+0xc001020a,0x0
+0xc001020b,0xffff
+0xc0011021,0x0
+0xc0011022,0x0
+0xc0011023,0x0
+0xc0011029,0x2
+0xc001102a,0x0
+0xc001102c,0x0
+0x400000000,0x0
+0x2000000000,0x0
+0x4000000000,0x0
+0x8000000000,0x0
+0x1000000000000,0x0
+0x3c000000000000,0x0
+0x80000000000000,0x0
+0x40000000000000,0x0