Officially onboard AMD Genoa #5088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5088 +/- ##
=======================================
Coverage 83.14% 83.14%
=======================================
Files 248 248
Lines 26923 26923
=======================================
Hits 22386 22386
Misses 4537 4537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JackThomson2
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
JackThomson2
force-pushed
the
feat/7a_onboarded
branch
2 times, most recently
from
fd644f7 to
9ae14ca
Compare
JackThomson2
added
the
Status: Awaiting review
Adding M7a to our default tested intances and the cross snapshot pipeline. Update the README to reflect this change. Signed-off-by: Jack Thomson <[email protected]>
We are investigating volatility in the tcp throughput on m7a for now we will ignore it, until we find a solution. Signed-off-by: Jack Thomson <[email protected]>
New entry in the changelog for AMD Genoa that is officially onboarded and tested on Firecracker Signed-off-by: Jack Thomson <[email protected]>
roypat
previously approved these changes
Mar 17, 2025
ShadowCurse
previously approved these changes
Mar 17, 2025
JackThomson2
force-pushed
the
feat/7a_onboarded
branch
from
2502938 to
c21f5da
Compare
Add m7a to the cpu template pipeline and add msr baselines for the variant. Signed-off-by: Jack Thomson <[email protected]>
JackThomson2
force-pushed
the
feat/7a_onboarded
branch
from
c21f5da to
18e18d9
Compare
Good catch thanks, included those now |
roypat
approved these changes
Mar 17, 2025
Manciukic
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding AMD Genoa as a supported instance for Firecracker
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.