Skip to content

Backport timeout fix for kani into firecracker-1.9 #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Backport timeout fix for kani into firecracker-1.9 #4766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/integration_tests/test_kani.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX-License-Identifier: Apache-2.0
"""
Proofs ensuring memory safety properites, user-defined assertions,
Proofs ensuring memory safety properties, user-defined assertions,
absence of panics and some types of unexpected behavior (e.g., arithmetic overflows).
"""
import os
Expand All @@ -14,7 +14,9 @@
PLATFORM = platform.machine()


@pytest.mark.timeout(1800)
# The `check_output` timeout will always fire before this one, but we need to
# set a timeout here to override the default pytest timeout of 180s.
@pytest.mark.timeout(2420)
@pytest.mark.skipif(PLATFORM != "x86_64", reason="Kani proofs run only on x86_64.")
@pytest.mark.skipif(
os.environ.get("BUILDKITE") != "true",
Expand All @@ -31,7 +33,8 @@ def test_kani(results_dir):
# --output-format terse is required by -j
# --enable-unstable is needed to enable `-Z` flags
_, stdout, _ = utils.check_output(
"cargo kani --enable-unstable -Z stubbing -Z function-contracts --restrict-vtable -j --output-format terse"
"cargo kani --enable-unstable -Z stubbing -Z function-contracts --restrict-vtable -j --output-format terse",
timeout=2400,
)

(results_dir / "kani_log").write_text(stdout, encoding="utf-8")
Loading