Backport timeout fix for kani into firecracker-1.9 #4766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
added
the
Status: Awaiting review
roypat
approved these changes
Sep 2, 2024
Some changes that we did in the VirtIO queue in this PR: firecracker-microvm#4726 pushed kani proofs close to the time limit we set in the CI. This commit just increases the timeout from 30 to 40 minutes. (cherry picked from commit b8ca08e) Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
backport_kani_time_limit_fix
branch
from
c8e30f9 to
5b90e07
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.9 #4766 +/- ##
=================================================
Coverage 84.34% 84.34%
=================================================
Files 249 249
Lines 27461 27461
=================================================
Hits 23162 23162
Misses 4299 4299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
approved these changes
Sep 2, 2024
ShadowCurse
approved these changes
Sep 2, 2024
bchalios
merged commit 7219252
into
firecracker-microvm:firecracker-v1.9
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backport fix for kani test that increases the timeout from 30 to 40 minutes.
Reason
Some changes that we did in the VirtIO queue in this PR: #4726 pushed kani proofs close to the time limit we set in the CI.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.