Fix Account deactivation issues #5721
Conversation
ariskotsomitopoulos
requested review from
a team and
fedrunov
and removed request for
a team
|
Thanks for handling issue about account deactivation. The code is quite tricky, and doing some test, there is still some issue (but no crash anymore) Trying to repro the other issue #3764: If I press back when I am prompt for my password, I get this popup, and I should not see it:
If I enter a wrong pwd I now have a stack of 2 account password prompt screen, that I can see by pressing back. With a correct pwd, I can deactivate an account 🎉 |
|
Yes, there is a lot of room for improvement here, I will check those flows |
|
@bmarty I added a cancelled state, so now when you press back, there will be no popup. Regarding the |
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.matrix.android.sdk.internal.auth.registration |
There was a problem hiding this comment.
Can you move it to api package? If you merge develop into your branch, there is now a uia sub-package
# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/tasks/InitializeCrossSigningTask.kt # vector/src/main/java/im/vector/app/features/settings/account/deactivation/DeactivateAccountViewModel.kt
|
(I let you manage the conflict :/) |
# Conflicts: # vector/src/main/java/im/vector/app/features/settings/account/deactivation/DeactivateAccountViewModel.kt
Done! Thanks! |
# Conflicts: # vector/src/main/java/im/vector/app/features/settings/account/deactivation/DeactivateAccountViewModel.kt
ariskotsomitopoulos
deleted the
feature/aris/fix_account_deactivation_issue
branch
This PR aims to Fix the following account deactivation issues:
Fixes a crash when the user navigates back from the deactivation/auth screen.
Closes Account Deactivation Error #5718
Closes Crash when cancelling account deactivation #3764
Fixing missing loader on account deactivation.
Closes Deactivating account not possible (loop) #5541