Skip to content

Fixed the intrinsic type name identifier typo from "instrinct" to "intrinsic" #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/models/types/intrinsic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class IntrinsicType extends Type {
/**
* The type name identifier.
*/
readonly type: string = 'instrinct'; // TODO: Is there any change to correct this typo?
readonly type: string = 'intrinsic';

/**
* Create a new instance of IntrinsicType.
Expand Down
12 changes: 6 additions & 6 deletions src/test/converter/access/specs.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "string"
}
},
Expand All @@ -71,7 +71,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "string"
}
},
Expand All @@ -97,7 +97,7 @@
"shortText": "A function that is made private via comment."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down Expand Up @@ -132,7 +132,7 @@
"shortText": "A function that is made protected via comment."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down Expand Up @@ -244,7 +244,7 @@
"shortText": "A function that is made private via comment."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down Expand Up @@ -279,7 +279,7 @@
"shortText": "A function that is made protected via comment."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down
34 changes: 17 additions & 17 deletions src/test/converter/class/specs.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"isArray": true,
"name": "number"
}
Expand All @@ -114,7 +114,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "string"
}
},
Expand Down Expand Up @@ -163,7 +163,7 @@
"shortText": "privateMethod short text."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down Expand Up @@ -196,7 +196,7 @@
"shortText": "protectedMethod short text."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down Expand Up @@ -229,7 +229,7 @@
"shortText": "publicMethod short text."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down Expand Up @@ -262,7 +262,7 @@
"shortText": "staticMethod short text."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down Expand Up @@ -360,7 +360,7 @@
"shortText": "Constructor param"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "any"
}
},
Expand All @@ -374,7 +374,7 @@
"shortText": "Private string property"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "string"
}
},
Expand All @@ -388,7 +388,7 @@
"shortText": "Public number property"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
},
Expand All @@ -402,7 +402,7 @@
"shortText": "Public implicit any property\n"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "any"
}
}
Expand Down Expand Up @@ -453,7 +453,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "string"
}
},
Expand All @@ -478,7 +478,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
},
Expand All @@ -503,7 +503,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "any"
}
},
Expand All @@ -527,7 +527,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "string"
},
"inheritedFrom": {
Expand Down Expand Up @@ -586,7 +586,7 @@
"shortText": "protectedMethod short text."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
},
"overwrites": {
Expand Down Expand Up @@ -629,7 +629,7 @@
"shortText": "publicMethod short text."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
},
"overwrites": {
Expand Down Expand Up @@ -672,7 +672,7 @@
"shortText": "staticMethod short text."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
},
"inheritedFrom": {
Expand Down
20 changes: 10 additions & 10 deletions src/test/converter/constructor-properties/specs.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"shortText": "X component of the Vector"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
},
Expand All @@ -64,7 +64,7 @@
"shortText": "Y component of the Vector\n"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
}
Expand Down Expand Up @@ -104,7 +104,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
},
Expand All @@ -128,7 +128,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
}
Expand Down Expand Up @@ -201,7 +201,7 @@
"shortText": "X component of the Vector"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
},
Expand All @@ -215,7 +215,7 @@
"shortText": "Y component of the Vector"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
},
Expand All @@ -229,7 +229,7 @@
"shortText": "Z component of the Vector\n"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
}
Expand Down Expand Up @@ -279,7 +279,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
},
"inheritedFrom": {
Expand Down Expand Up @@ -308,7 +308,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
},
"overwrites": {
Expand Down Expand Up @@ -337,7 +337,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "number"
}
}
Expand Down
16 changes: 8 additions & 8 deletions src/test/converter/decorators/specs.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"id": 13
},
"arguments": {
"options": "{\n name: 'Name of class'\n}"
"options": "{\r\n name: 'Name of class'\r\n}"
}
}
],
Expand Down Expand Up @@ -75,7 +75,7 @@
"shortText": "A decorated method."
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down Expand Up @@ -151,11 +151,11 @@
"type": "union",
"types": [
{
"type": "instrinct",
"type": "intrinsic",
"name": "string"
},
{
"type": "instrinct",
"type": "intrinsic",
"name": "symbol"
}
]
Expand All @@ -172,15 +172,15 @@
"name": "TypedPropertyDescriptor",
"typeArguments": [
{
"type": "instrinct",
"type": "intrinsic",
"name": "any"
}
]
}
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "void"
}
}
Expand Down Expand Up @@ -252,7 +252,7 @@
}
],
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "string"
}
}
Expand Down Expand Up @@ -325,7 +325,7 @@
"text": "The parameter of this decorator.\n"
},
"type": {
"type": "instrinct",
"type": "intrinsic",
"name": "boolean"
}
}
Expand Down
Loading