Skip to content

Fixed the intrinsic type name identifier typo from "instrinct" to "intrinsic" #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2017

Conversation

rklfss
Copy link
Contributor

@rklfss rklfss commented Apr 25, 2017

This PR fixes the type name identifier of the "intrinsic" type which was "instrinct" before.

Changed the type model, test specs were updated automatically.

As this is a breaking change, the minor version was incremented.
So as of 0.6.0 if you rely on the output of typedoc using the --json option, please check your code for the occurrence of "instrinct"!

closes #146

@blakeembrey
Copy link
Member

Please don't change the version number. I can merge any fixes when you undo it.

@rklfss
Copy link
Contributor Author

rklfss commented Apr 25, 2017

Sorry about that. I was unsure about your comment in #482

@blakeembrey
Copy link
Member

No problem. You generally avoid bumping versions, especially as part of a feature, because people normally have an existing release process and tagging to do. I just meant I would bump the minor version when we release this 😄

@blakeembrey blakeembrey merged commit f04d994 into TypeStrong:master Apr 25, 2017
@rklfss rklfss deleted the intrinsic-typo branch April 26, 2017 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Type Typo in Generated JSON
2 participants