Skip to content

Dates in recipient headers #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnprice opened this issue Jun 9, 2023 · 0 comments · Fixed by #283
Closed

Dates in recipient headers #172

gnprice opened this issue Jun 9, 2023 · 0 comments · Fixed by #283
Assignees
@gnprice
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone
M0: Alpha

Comments

@gnprice
Copy link
Member

gnprice commented Jun 9, 2023

The current prototype shows the time of each message, but only modulo 24 hours — we don't show its date. We should show the date.

Specifically, like Zulip web and zulip-mobile, we should do so at the right/end of the recipient header.
@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label Jun 9, 2023
@gnprice gnprice added this to the Alpha milestone Jun 9, 2023
This was referenced Jun 9, 2023
Closed
Closed
gnprice added a commit that referenced this issue Jun 9, 2023
@gnprice
doc: Start converting readme's TODOs into GitHub issues
175cf46 
Filed issues #161, #162, #163, #164, #165, #166, #167, #168, #169,
 #170, #171, #172, #173, #174, #175.
@gnprice gnprice self-assigned this Jul 17, 2023
This was referenced Aug 17, 2023
Open
Open
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Aug 23, 2023
@gnprice
msglist test: Use default screen size
b3f43da 
This size is in *physical* pixels, not logical -- so with the
tests' default device pixel ratio of 3, it corresponds to
200w267h in logical pixels, which is a very small screen.
(It's a bit over 2 inches (53mm) diagonal when converted at
160px/in, which is the nominal value for a logical pixel.)

Better to use the default size, which is somewhat more realistic.
In particular, we have a known issue (zulip#282) that the recipient headers
suffer overflow if a stream name is long.  This tiny screen causes
that issue to appear even when a name is not very long at all;
and when we add dates to the recipient headers (zulip#172), it would
start happening in the tests as they stand.

A handful of tests need adjustments to keep working with the new
size, mostly just to fill the message list with more messages.
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Aug 23, 2023
@gnprice
msglist: Show date in recipient headers
f2bca87 
Fixes: zulip#172
@gnprice gnprice mentioned this issue Aug 23, 2023
Merged
gnprice added a commit that referenced this issue Aug 24, 2023
@gnprice
msglist test: Use default screen size
27699de 
This size is in *physical* pixels, not logical -- so with the
tests' default device pixel ratio of 3, it corresponds to
200w267h in logical pixels, which is a very small screen.
(It's a bit over 2 inches (53mm) diagonal when converted at
160px/in, which is the nominal value for a logical pixel.)

Better to use the default size, which is somewhat more realistic.
In particular, we have a known issue (#282) that the recipient headers
suffer overflow if a stream name is long.  This tiny screen causes
that issue to appear even when a name is not very long at all;
and when we add dates to the recipient headers (#172), it would
start happening in the tests as they stand.

A handful of tests need adjustments to keep working with the new
size, mostly just to fill the message list with more messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnprice gnprice

Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: Done
Milestone
M0: Alpha
Development

Successfully merging a pull request may close this issue.

Show dates in recipient headers, and DM interlocutors' names gnprice/zulip-flutter
1 participant
@gnprice