compiler: make @export take a pointer (#14911)
#21206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mlugg <[email protected]>
|
nice |
mlugg
added
breaking
andrewrk
approved these changes
Aug 26, 2024
|
Superceded by #21214. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages. Nice simple one.
There's a TODO compile error for something newly allowed by this which we should probably add support for; I will open a corresponding issue.
@andrewrk, note that both this and #21191 require
zig1.wasmupdates. Therefore, if you're happy with both branches, I can combine these two proposal implementations into one branch to minimize overall zig1 updates.