ci: workflows: check for manifest dnm in the manifest workflow #88952
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current CI setup sets the manifest DNM label in a workflow and checks it in a different workflow. The one performing the check is configured to rerun on label changes but it's been reported few times that the rerun logic does not seem to always run effectively and there's been cases where the manifest has been fixed but the label has not been removed by the automation, resulting in a stale PR. Since the manifest has its own dedicated label, fix this race condition by checking for that label specifically in the manifest workflow rather than in a separate one, this means that the check is always performed after the script that sets the label. It also means that on manifest changes the manifest step itself will fail rather than the PR metadata check one. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
added
DNM (manifest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CI setup sets the manifest DNM label in a workflow and checks it in a different workflow. The one performing the check is configured to rerun on label changes but it's been reported few times that the rerun logic does not seem to always run effectively and there's been cases where the manifest has been fixed but the label has not been removed by the automation, resulting in a stale PR.
Since the manifest has its own dedicated label, fix this race condition by checking for that label specifically in the manifest workflow rather than in a separate one, this means that the check is always performed after the script that sets the label.
It also means that on manifest changes the manifest step itself will fail rather than the PR metadata check one.