Return scalar when accessing zero dimensional array #2718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to return scalars when accessing zero-dimensional arrays? This would mean that the return value of |
|
To copy what numpy does (see #2713 (comment)), I think we do want to return a scalar. |
github-actions
bot
added
the
needs release notes
|
@d-v-b what do you think about |
# Conflicts: # src/zarr/api/synchronous.py
# Conflicts: # tests/test_api.py
normanrz
approved these changes
Apr 7, 2025
d-v-b
pushed a commit
to d-v-b/zarr-python
that referenced
this pull request
Apr 20, 2025
…2718) * Return scalar when accessing zero dimensional array * returning npt.ArrayLike instead of NDArrayLike because of scalar return values * returning npt.ArrayLike instead of NDArrayLike because of scalar return values * fix mypy in tests * fix mypy in tests * fix mypy in tests * improve test_scalar_array * fix typo * add ScalarWrapper * use ScalarWrapper as NDArrayLike * Revert "fix mypy in tests" * Revert "fix mypy in tests" This reverts commit 75d6cdf. * Revert "fix mypy in tests" This reverts commit 34bf260. * format * Revert "returning npt.ArrayLike instead of NDArrayLike because of scalar return values" This reverts commit 1a290c7. * Revert "returning npt.ArrayLike instead of NDArrayLike because of scalar return values" This reverts commit 3348439 * fix mypy for ScalarWrapper * add missing import NDArrayLike * ignore unavoidable mypy error * format * fix __array__ * extend tests * format * fix typing in test_scalar_array * add dtype to ScalarWrapper * correct dtype type * fix test_basic_indexing * fix test_basic_indexing * fix test_basic_indexing for dtype=datetime64[Y] * increase codecov * fix typing * document changes * move test_scalar_wrapper to test_buffer.py * remove ScalarWrapper usage * create NDArrayOrScalarLike * fix NDArrayOrScalarLike * fix mypy * fix mypy * fix mypy * fix mypy in asynchronous.py * fix mypy in test_api.py * fix mypy in test_api.py and synchronous.py * fix mypy in test_api.py and test_array.py * fix mypy in test_array.py * fix mypy in test_array.py * fix mypy in test_array.py * fix mypy in test_array.py * fix mypy in test_array.py, test_api.py, test_buffer.py, test_sharding.py * add bytes, str and datetime to ScalarType * only support numpy datetime64 in ScalarType * remove ScalarWrapper and update changes * undo wrong code changes * rename ``NDArrayOrScalarLike`` to ``NDArrayLikeOrScalar`` * rename ``NDArrayOrScalarLike`` to ``NDArrayLikeOrScalar`` * fix mypy in test_array.py * fix mypy in test_array.py * handle datetype scalars for different units * fix mypy * fix mypy * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
()indexing/size behavior from v2->v3 #27130-dimensional arrays are now returning a scalar. Therefore, the return type of
__getitem__changedto NDArrayOrScalarLike. This change is to make the behavior of 0-dimensional arrays consistent with
numpyscalars.TODO:
docs/user-guide/*.rstchanges/