Skip to content

exosip: add windows platform #6971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 26, 2025
Merged

exosip: add windows platform #6971

merged 22 commits into from
Apr 26, 2025

Conversation

luadebug
Copy link
Contributor

@luadebug luadebug commented Apr 23, 2025

During shared build on Windows it would miss deps LNK2001/LNK2019. Yet reworked .def file that I've made, some funcs got removed in newer versions so I removed non-existing symbols out of .def file, but yet it might require adding more of symbols into .def file, and I'm not sure if it links against deps during shared build .DLL.

LIBRARY "eXosip2.dll"


EXPORTS
     eXosip_init     @1
     eXosip_quit     @2
     eXosip_set_option     @3
     eXosip_lock     @4
     eXosip_unlock     @5
     eXosip_listen_addr     @6
     eXosip_set_socket     @7
     eXosip_set_user_agent     @8
     eXosip_masquerade_contact     @9
     eXosip_add_authentication_info     @10
     eXosip_clear_authentication_info     @11
     eXosip_default_action     @12
     eXosip_automatic_action     @13
     eXosip_generate_random     @14
     eXosip_hexa_generate_random     @15
     eXosip_byte_generate_random     @16
     eXosip_event_free     @17
     eXosip_event_wait     @18
     eXosip_event_get     @19
     eXosip_insubscription_build_answer     @20
     eXosip_insubscription_send_answer     @21
     eXosip_insubscription_build_request     @22
     eXosip_insubscription_build_notify     @23
     eXosip_insubscription_send_request     @24
     eXosip_register_build_initial_register     @25
     eXosip_register_build_initial_register_withqvalue     @26
     eXosip_register_build_register     @27
     eXosip_register_send_register     @28
     eXosip_register_remove     @29
     eXosip_message_build_request     @30
     eXosip_message_send_request     @31
     eXosip_message_build_answer     @32
     eXosip_message_send_answer     @33
     eXosip_build_publish     @34
     eXosip_publish     @35
     eXosip_options_build_request     @36
     eXosip_options_send_request     @37
     eXosip_options_build_answer     @38
     eXosip_options_send_answer     @39
     eXosip_transport_set     @40
     eXosip_guess_localip     @41
     eXosip_get_remote_sdp     @42
     eXosip_get_local_sdp     @43
     eXosip_get_remote_sdp_from_tid     @44
     eXosip_get_local_sdp_from_tid     @45
     eXosip_get_sdp_info     @46
     eXosip_get_audio_connection     @47
     eXosip_get_audio_media     @48
     eXosip_get_video_connection     @49
     eXosip_get_video_media     @50

eXutils.c:308:9: error: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion]

  308 |   char *tmp = strerror_r(errnum, buf + in, buflen - in);

Yet trying to resolve this by _GNU_SOURCE=1

@luadebug luadebug marked this pull request as draft April 23, 2025 20:14
Comment on lines -22 to -32
on_check("macosx", function (package)
assert(package:check_cxxsnippets({test = [[
#include "TargetConditionals.h"
#include <CoreFoundation/CoreFoundation.h>
#include <CoreServices/CoreServices.h>
#include <Security/Security.h>
void test() {
SInt32 osx_version = 0;
OSErr res = Gestalt(gestaltSystemVersion, &osx_version);
}
]]}))
Copy link
Contributor Author

@luadebug luadebug Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly add_frameworks("CoreFoundation") is only being added.

@luadebug
Copy link
Contributor Author

luadebug commented Apr 24, 2025

Mirror keeps falling. fatal: unable to access 'https://git.savannah.gnu.org/git/osip.git/': The requested URL returned error: 502
But I do not know what mirrors stores these files, so we could push more mirrors... Uploading to xmake-mirror or either rework into https://www.antisip.com/download/exosip2/?

@luadebug
Copy link
Contributor Author

Pushed #6979 for mirror of osip project.

@luadebug luadebug marked this pull request as ready for review April 25, 2025 08:41
@luadebug
Copy link
Contributor Author

luadebug commented Apr 25, 2025

I do not know why this Mac OS X error appear...

add_frameworks("CoreFoundation", "CoreServices", "Security")
ld: Undefined symbols:
  _CFRelease, referenced from:
      __tls_add_certificates in eXtl_tls.o
      __tls_add_certificates in eXtl_tls.o
      __tls_add_certificates in eXtl_tls.o
  _Gestalt, referenced from:
      __tls_add_certificates in eXtl_tls.o
  _SecKeychainItemCopyAttributesAndData, referenced from:
      __tls_add_certificates in eXtl_tls.o
  _SecKeychainItemFreeAttributesAndData, referenced from:
      __tls_add_certificates in eXtl_tls.o
  _SecKeychainOpen, referenced from:
      __tls_add_certificates in eXtl_tls.o
      __tls_add_certificates in eXtl_tls.o
  _SecKeychainSearchCopyNext, referenced from:
      __tls_add_certificates in eXtl_tls.o
  _SecKeychainSearchCreateFromAttributes, referenced from:
      __tls_add_certificates in eXtl_tls.o
error: @programdir/core/sandbox/modules/os.lua:273: aclocal.m4:17: warning: this file was generated for autoconf 2.69.
You have another version of autoconf.  It may work, but is not guaranteed to.
If you have problems, you may need to regenerate the build system entirely.
To do so, use the procedure documented by the package, typically 'autoreconf'.
configure.ac:24: error: version mismatch.  This is Automake 1.16.5,
configure.ac:24: but the definition used by this AM_INIT_AUTOMAKE
configure.ac:24: comes from Automake 1.16.1.  You should recreate
configure.ac:24: aclocal.m4 with aclocal and run automake again.
WARNING: 'automake-1.16' is probably too old.
         You should only need it if you modified 'Makefile.am' or
         'configure.ac' or m4 files included by 'configure.ac'.
         The 'automake' program is part of the GNU Automake package:
         <https://www.gnu.org/software/automake>
         It also requires GNU Autoconf, GNU m4 and Perl in order to run:
         <https://www.gnu.org/software/autoconf>
         <https://www.gnu.org/software/m4/>
         <https://www.perl.org/>
make[2]: *** [Makefile.in] Error 63
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

stack traceback:
    [C]: in function 'error'
    [@programdir/core/base/os.lua:1075]:
    [@programdir/core/sandbox/modules/os.lua:273]:
    [@programdir/core/sandbox/modules/os.lua:291]: in function 'vrunv'
    [@programdir/modules/package/tools/autoconf.lua:561]: in function 'make'
    [@programdir/modules/package/tools/autoconf.lua:590]: in function 'build'
    [@programdir/modules/package/tools/autoconf.lua:598]: in function 'install'
    [...r/work/xmake-repo/xmake-repo/packages/e/exosip/xmake.lua:144]: in function 'script'
    [...dir/modules/private/action/require/impl/utils/filter.lua:114]: in function 'call'
    [.../modules/private/action/require/impl/actions/install.lua:452]:

  => install exosip 5.3.0 .. failed

Re-runing worker resolves something like this^

@waruqi waruqi merged commit efcf382 into xmake-io:dev Apr 26, 2025
79 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants