fix: Prevent Unlisted CSS from being excluded in the build when using CSS preprocessor #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, the build function of
viteBuilderdetermines whether a file is a CSS entrypoint by checking if its file extension ends with.css. As a result, Unlisted CSS using preprocessors like Sass are not built as CSS entrypoints and ignored during the build.This PR updates the CSS entrypoint detection to use the
group.typevalue and adds e2e tests for CSS entrypoints.This is my first PR to an open-source project, so if there's anything I missed or did incorrectly, please let me know. Thanks!
Manual Testing
Please check the CSS entrypoint e2e tests I added to the PR.
Related Issue
This PR closes #1580.