Skip to content

library: Add CSS gradients demo #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

UrtsiSantsi
Copy link
Contributor

Fixes #600

@UrtsiSantsi UrtsiSantsi requested a review from sonnyp as a code owner September 24, 2023 01:10
@UrtsiSantsi UrtsiSantsi force-pushed the css_gradient branch 3 times, most recently from 8e10aaa to 8dfb872 Compare September 24, 2023 01:45
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic work, thank you!

I love how the top part of the demo demonstrates plain and simple css to read and understand and the second is an interactive designer.

I did a little design review

@bragefuglseth recommended making the list a bit wider.

And Alice said

also the angles of the previews are slanted
there's clearly another color behind the gradient

@sonnyp
Copy link
Contributor

sonnyp commented Sep 24, 2023

Ho and please don't forget to add yourself to the contributors in about.js

@UrtsiSantsi
Copy link
Contributor Author

I think I resolved all comments, except for Alice's

also the angles of the previews are slanted
there's clearly another color behind the gradient

I don't see the slanted angles and I used the same gradient in Firefox and it looked the same.

@sonnyp sonnyp changed the title Add CSS gradients demo library: Add CSS gradients demo Sep 25, 2023
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I made a few minor tweaks which might be interesting 8e78a20

For next time:

Please prefix PR titles with "library: " if relevant

Avoid force push and deleting previous commits, it makes reviewing harder. When accepting PRs we use "Squash and merge" anyway so all commits are combined into one with the title of the PR as commit message.

@sonnyp sonnyp merged commit 683eece into workbenchdev:main Sep 25, 2023
@sonnyp
Copy link
Contributor

sonnyp commented Sep 25, 2023

https://floss.social/@sonny/111125264888166516 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS gradient demo
2 participants