-
-
Notifications
You must be signed in to change notification settings - Fork 88
library: Add CSS gradients demo #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e10aaa
to
8dfb872
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic work, thank you!
I love how the top part of the demo demonstrates plain and simple css
to read and understand and the second is an interactive designer.
I did a little design review
@bragefuglseth recommended making the list a bit wider.
And Alice said
also the angles of the previews are slanted
there's clearly another color behind the gradient
Ho and please don't forget to add yourself to the contributors in |
8dfb872
to
453220f
Compare
453220f
to
b64c29e
Compare
I think I resolved all comments, except for Alice's
I don't see the slanted angles and I used the same gradient in Firefox and it looked the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I made a few minor tweaks which might be interesting 8e78a20
For next time:
Please prefix PR titles with "library: " if relevant
Avoid force push and deleting previous commits, it makes reviewing harder. When accepting PRs we use "Squash and merge" anyway so all commits are combined into one with the title of the PR as commit message.
Fixes #600