Re-add Symfony Serializer for JWE/JWS #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 665cd89 the Symfony Normalizers were removed because of the more extensive type hinting in Symfony 6.0.
With this PR I restore the compatibility with Symfony Serializer 6.0. By implementing the
NormalizationAwareInterfacewe now instruct the serializer to skip the normalization step normally done when callingserialize(). This fixes the main problem that was faced when type hinting for version 3.0.There are no separate encoders and normalizers anymore. Both JWS and JWE have their own serializer class now which handles everything. These classes also no longer implement the
NormalizerInterfaceanymore as we completely skip that step. I wish I could do the same for denormalization but we still have to do it the old fashion way, by passing through the data that came in. Luckily the return type ismixedso this doesn't cause any trouble.Please let me know what you think!