Enhancement/decrypt pkcs8 private keys #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @skydudie, You are right, The old fashion code for old OpenSSL version I wrote few years ago could be enhanced now. Regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a similar situation as #258 where I has been given a PKCS#8 Private Encrypted Key generated from OpenSSL. The framework was unable to decrypt it as the function loadKeyFromPEM was only looking for a PKCS#1 formatted encrypted key. Since openssl_pkey_get_private supports decrypting PKCS#8 formatted encrypted keys, I thought it might be useful to add another if block to the function to try and decrypt it.
Do let me know if this is something you'd think might be useful or if I had missed anything out of the PR (: