Add support for annotated types #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review tomorrow. Thanks for putting this together!
… On 3 Apr 2017, at 10:39 pm, Dominique Hazael-Massieux ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#61
Commit Summary
Add support for annotated types
Adapt test to support for annotated types
File Changes
M lib/webidl2.js (25)
M test/syntax/idl/uniontype.widl (1)
M test/syntax/json/identifier-qualified-names.json (3)
M test/syntax/json/typedef.json (17)
M test/syntax/json/uniontype.json (200)
Patch Links:
https://github.com./w3c/webidl2.js/pull/61.patch
https://github.com./w3c/webidl2.js/pull/61.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
marcoscaceres
requested changes
Apr 4, 2017
test/syntax/json/uniontype.json
Outdated
| "idlType" : { | ||
| "idlType" : [ | ||
| { | ||
| "array" : false, |
There was a problem hiding this comment.
What's outputting this that it's putting a space after the property name? Can we please not do that?
There was a problem hiding this comment.
(eventually, we might want to generate this stuff using JSON.stringify() and we won't be able to match this format).
| @@ -255,6 +255,13 @@ | |||
| return single_type() || union_type(); | |||
| }; | |||
|
|
|||
| var type_with_extended_attributes = function() { | |||
There was a problem hiding this comment.
Thankfully, this was not too painful 🏆
marcoscaceres
approved these changes
Apr 4, 2017
|
Merge when ready 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.