Skip to content

fix: require dictionary default value only when optional #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2019
Merged

fix: require dictionary default value only when optional #359

merged 3 commits into from
Jul 13, 2019

Conversation

saschanaz
Copy link
Member

Oops 😅

@saschanaz saschanaz requested a review from marcoscaceres July 13, 2019 03:45
@saschanaz saschanaz mentioned this pull request Jul 13, 2019
Merged
marcoscaceres
marcoscaceres approved these changes Jul 13, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@saschanaz saschanaz merged commit f452007 into gh-pages Jul 13, 2019
@saschanaz saschanaz deleted the only-optional branch July 13, 2019 05:24
@marcoscaceres marcoscaceres mentioned this pull request Jul 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanaz @marcoscaceres