BREAKING CHANGE: remove all trivia fields #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
Apr 18, 2019
saschanaz
added a commit
that referenced
this pull request
Apr 24, 2021
This adds write() to eof object so that writer can stop special casing it. The tokeniser now also adds line/index fields to eof token for consistency with other tokens. This removes `trivia` field from EOF. Theoretically it can be a breaking change, but trivia strings are not intended to be accessed outside of the writer function since #306. So I think it's safe to not mark it as breaking.
saschanaz
added a commit
that referenced
this pull request
Aug 9, 2021
* refactor: wrap EOF token This adds write() to eof object so that writer can stop special casing it. The tokeniser now also adds line/index fields to eof token for consistency with other tokens. This removes `trivia` field from EOF. Theoretically it can be a breaking change, but trivia strings are not intended to be accessed outside of the writer function since #306. So I think it's safe to not mark it as breaking. * Update token.js * Update buffersource.json * Update syntax.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
genericnow always returns string rather thannullor an object.