Skip to content

refactor: remove remaining JSON idlTypes #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2019
Merged

refactor: remove remaining JSON idlTypes #291

merged 2 commits into from
Mar 18, 2019

Conversation

saschanaz
Copy link
Member

#262 will be finally reviewable after this.

@saschanaz saschanaz requested a review from marcoscaceres March 18, 2019 10:41
marcoscaceres
marcoscaceres reviewed Mar 18, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 💪

@saschanaz
Copy link
Member Author

Looking great! 💪

👍 🎉 , but... would you approve this then? 🤣

marcoscaceres
marcoscaceres approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, pushing buttons is hard!

@saschanaz saschanaz merged commit 852194f into gh-pages Mar 18, 2019
@saschanaz saschanaz deleted the class-idltypes branch March 18, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanaz @marcoscaceres