BREAKING CHANGE: constant as a class #280
Conversation
| } | ||
| const { trivia } = token; | ||
| let data; | ||
| return consume("true", "false", "null", "Infinity", "-Infinity", "NaN", FLOAT, INT); |
There was a problem hiding this comment.
FLOAT, INT add indirection, why not just inline them? or do they have some special definition?
There was a problem hiding this comment.
It's LONG and used twice (from constants and default values). Not great to inline IMO.
There was a problem hiding this comment.
Ok, I figured:) thought I’d ask.
There was a problem hiding this comment.
Oops, maybe I misunderstood, I thought you asked about inlining const_value() which contains them.
For FLOAT/INT/STR/ID, they have slightly different meaning. Typically consume("text") means consuming a token which is exactly text, but in those cases regex is used instead.
There was a problem hiding this comment.
ah, right. Sorry, I was reviewing on my phone and should have checked that. Using regexes 👍 makes sense then.
This removes
valueLiteralwriter hook because it turns out that ReSpec doesn't need it.