Add trivia for partial types #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/webidl2.js
Outdated
| @@ -851,7 +851,7 @@ | |||
| return ret; | |||
| } | |||
|
|
|||
| function interface_rest(isPartial, typeName = "interface") { | |||
| function interface_rest(partialModifier = null, typeName = "interface") { | |||
There was a problem hiding this comment.
I'd really prefer if this was:
interface_rest(typeName = "interface", { partialModifier = null } ) {It kills the annoying partialModifier boolean/null trap.
marcoscaceres
requested changes
Jun 13, 2018
lib/webidl2.js
Outdated
| @@ -889,7 +889,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| function mixin_rest(isPartial) { | |||
| function mixin_rest(partialModifier = null) { | |||
There was a problem hiding this comment.
I guess same applies here.
lib/webidl2.js
Outdated
| @@ -927,17 +927,17 @@ | |||
| } | |||
| } | |||
|
|
|||
| function interface_(isPartial) { | |||
| function interface_(partialModifier = null) { | |||
There was a problem hiding this comment.
same... and for the others too.
marcoscaceres
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames a local variable
isPartialaspartialModifier.