Add trivia for idlTypes #192
Conversation
| @@ -195,9 +195,13 @@ | |||
|
|
|||
| const EMPTY_IDLTYPE = Object.freeze({ | |||
| generic: null, | |||
| nullable: false, | |||
| nullable: null, | |||
There was a problem hiding this comment.
Can you help me understand why we don’t default to false? Null seems a little odd here.
| obj.nullable = !!consume("?"); | ||
| const nullable = consume("?"); | ||
| if (nullable) { | ||
| obj.nullable = { trivia: nullable.trivia }; |
There was a problem hiding this comment.
Can you help me understand why we don’t default to false?
@marcoscaceres I had to determine where should information about optional "modifier" tokens go, and the result is this.
I could do idlType.trivia.nullable === null, but then we would have two fields about nullable token being absent, and causes inconsistency (some trivia fields sometimes being null, others never). Having two fields also may cause bugs as we should manage those simultaneously.
The null way keeps compatibility with if (idlType.nullable) and can also benefit from future optional chaining syntax: idlType.nullable?.trivia.
There was a problem hiding this comment.
Thanks for the clarification, makes sense.
These four commits are mutually related (so I couldn't fix writer.js for each commit), but still each commit has its own baseline changes.