-
-
Notifications
You must be signed in to change notification settings - Fork 64
BREAKING CHANGE: remove idlType.sequence #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
May 25, 2018
csnardi
added a commit
to csnardi/web-platform-tests
that referenced
this pull request
Jun 1, 2018
idlType.sequence was removed in w3c/webidl2.js#175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it.
zcorpan
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 1, 2018
idlType.sequence was removed in w3c/webidl2.js#175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it.
mrego
pushed a commit
to mrego/wpt
that referenced
this pull request
Jun 4, 2018
idlType.sequence was removed in w3c/webidl2.js#175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 10, 2018
…lType.generic, a=testonly Automatic update from web-platform-testsCheck if a type is a sequence through idlType.generic idlType.sequence was removed in w3c/webidl2.js#175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it. -- wpt-commits: b1a1415cdf23bb3dc5c2f2ccb58a7abe87b93961 wpt-pr: 11286
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Jun 12, 2018
…lType.generic, a=testonly Automatic update from web-platform-testsCheck if a type is a sequence through idlType.generic idlType.sequence was removed in w3c/webidl2.js#175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it. -- wpt-commits: b1a1415cdf23bb3dc5c2f2ccb58a7abe87b93961 wpt-pr: 11286
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…lType.generic, a=testonly Automatic update from web-platform-testsCheck if a type is a sequence through idlType.generic idlType.sequence was removed in w3c/webidl2.js#175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it. -- wpt-commits: b1a1415cdf23bb3dc5c2f2ccb58a7abe87b93961 wpt-pr: 11286 UltraBlame original commit: 460ddda505c070dbddfc25efa2b558ca023495e4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…lType.generic, a=testonly Automatic update from web-platform-testsCheck if a type is a sequence through idlType.generic idlType.sequence was removed in w3c/webidl2.js#175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it. -- wpt-commits: b1a1415cdf23bb3dc5c2f2ccb58a7abe87b93961 wpt-pr: 11286 UltraBlame original commit: 460ddda505c070dbddfc25efa2b558ca023495e4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…lType.generic, a=testonly Automatic update from web-platform-testsCheck if a type is a sequence through idlType.generic idlType.sequence was removed in w3c/webidl2.js#175, as the same check can be achieved through `idlType.generic === "sequence"`. Move to this more updated syntax so that updating webidl2.js will require less work the next time we do it. -- wpt-commits: b1a1415cdf23bb3dc5c2f2ccb58a7abe87b93961 wpt-pr: 11286 UltraBlame original commit: 460ddda505c070dbddfc25efa2b558ca023495e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174