Let error messages include the current definition name #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lol, I was working on these also today and you beat me to it 💃 |
|
Should we deal with partials? |
|
That is, should the error say, for example, " |
|
Oh, partial definitions... It should also be simple enough, so yeah I will push one more commit. |
|
Ignore my comment above. I see it's handled by |
|
Oh, wait, maybe it's not handled by type... it must be Friday! |
|
Callback interfaces should also be supported, currently an error will call it just an interface. |
|
Friday commits added! |
marcoscaceres
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
This should be simple enough 😁