Skip to content

DO NOT MERGE YET: Drop support for implements statement #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

saschanaz
Copy link
Member

Fixes #98, but merge after specs remove the syntax.

@marcoscaceres
Copy link
Member

@saschanaz, when you have minute, could you please rebase?

@marcoscaceres
Copy link
Member

@saschanaz, you should probably rebase this before it gets worst.

@saschanaz saschanaz force-pushed the remove-implements branch 3 times, most recently from f1303a9 to 19f13d3 Compare May 6, 2018 12:48
@saschanaz
Copy link
Member Author

Travis says "This is not an active repository", any idea what happened there? @marcoscaceres

@marcoscaceres
Copy link
Member

No. We (folks in W3C collaboration teams) have randomly had Travis being disabled. We've asked GitHub for help, but they were not able to isolate the problem. Looking at Settings for the repo, I see a Services deprecation warning, with related blog post: https://developer.github.com./changes/2018-04-25-github-services-deprecation/

@marcoscaceres
Copy link
Member

Sent an empty commit in an attempt to restart Travis. This branch wasn't showing up :/

@saschanaz saschanaz closed this May 7, 2018
@saschanaz saschanaz reopened this May 7, 2018
@marcoscaceres
Copy link
Member

Starting to get a little of bit of bit rot here. @saschanaz, mind updating it?

@saschanaz saschanaz force-pushed the remove-implements branch 3 times, most recently from 962149d to 5a7e8c6 Compare May 16, 2018 15:39
@saschanaz saschanaz force-pushed the remove-implements branch from 5a7e8c6 to 4796133 Compare May 20, 2018 07:28
@saschanaz
Copy link
Member Author

Do we still have a blocker here?

@marcoscaceres
Copy link
Member

@marcoscaceres
Copy link
Member

It might accelerate things if we send a PR to fix w3c/webappsec-credential-management#111. @saschanaz, I've not looked at the appropriate use of mixin, so would you be willing to send them one?

@marcoscaceres
Copy link
Member

Once the Credential Management spec is fixed, I think it automatically fixes web-platform-tests/wpt#8053 - because all the updated specs will be testing what was required there.

I've asked @tobie to clarify if my assumption holds.

@saschanaz saschanaz force-pushed the remove-implements branch 3 times, most recently from caf8bb0 to 32f76c9 Compare May 30, 2018 07:41
@saschanaz saschanaz force-pushed the remove-implements branch from 32f76c9 to f8ef299 Compare June 19, 2018 06:44
@marcoscaceres
Copy link
Member

I think we should consider merging this. All the specs have been updated. The WPT issues can be fixed incrementally (along with any now outdated WebIDL in WPT).

@saschanaz saschanaz force-pushed the remove-implements branch from f8ef299 to 98125c4 Compare July 5, 2018 05:15
@saschanaz
Copy link
Member Author

I have no objection. I know some specs haven't updated their snapshots yet, but that's okay for me.

@marcoscaceres marcoscaceres merged commit b2a9f6c into develop Jul 5, 2018
@marcoscaceres
Copy link
Member

#yolo 😅

@marcoscaceres marcoscaceres deleted the remove-implements branch July 5, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants