Skip to content

Fix perform and release actions for valid browsing context check and handle alert step #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

Fix perform and release actions for valid browsing context check and handle alert step #1877

merged 1 commit into from
Jan 31, 2025

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Jan 31, 2025 •
edited by pr-preview bot
Loading

@whimboo whimboo requested review from jgraham and OrKoN January 31, 2025 15:20
whimboo
whimboo commented Jan 31, 2025
View reviewed changes
index.html
Comment on lines +10273 to +10278
<li><p>If <var>session</var>&apos;s <a>current browsing context</a>
is <a>no longer open</a>, return <a>error</a> with <a>error code</a>
<a>no such window</a>.

<li><p><a>Try</a> to <a>handle any user prompts</a> with <var>session</var>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this up as well given that there is no need to extract / process an action sequence when we have to fail anyway.

@whimboo whimboo merged commit 78d3c9b into w3c:master Jan 31, 2025
2 checks passed
@whimboo whimboo deleted the release_actions_alert branch January 31, 2025 15:34
github-actions bot added a commit that referenced this pull request Jan 31, 2025
@whimboo @github-actions
Fix perform and release actions for valid browsing context check and …
80e0506 
…handle alert step (#1877)

SHA: 78d3c9b
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com.>
github-actions bot added a commit to ZRDKPoWeR/webdriver that referenced this pull request Jan 31, 2025
@whimboo @github-actions
Fix perform and release actions for valid browsing context check and …
b15ebd8 
…handle alert step (w3c#1877)

SHA: 78d3c9b
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com.>
github-actions bot added a commit to soloinovator/webdriver that referenced this pull request Jan 31, 2025
@whimboo @github-actions
Fix perform and release actions for valid browsing context check and …
3cdefe2 
…handle alert step (w3c#1877)

SHA: 78d3c9b
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com.>
github-actions bot added a commit to xjc90s/webdriver that referenced this pull request Feb 1, 2025
@whimboo @github-actions
Fix perform and release actions for valid browsing context check and …
0dae3dc 
…handle alert step (w3c#1877)

SHA: 78d3c9b
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

@jgraham jgraham Awaiting requested review from jgraham

Assignees
No one assigned
Labels
bug Perform Actions Release Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whimboo @OrKoN