Skip to content

feat(loader): support options.productionMode #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2018
Merged

feat(loader): support options.productionMode #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c66ee8
fix(loader): use options.minimize
pi0 Mar 23, 2018
88592e5
misc(loader): rename options.minimize ~> options. productionMode
Mar 23, 2018
0677d19
feat(doc): add productionMode to options list
Mar 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,3 +222,4 @@ The following option has been changed to resourceQuery:
- `transformAssetUrls`
- `optimizeSSR`
- `hotReload`
- `productionMode`
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module.exports = function (source) {

const isServer = target === 'node'
const isShadow = incomingQuery.shadow != null
const isProduction = minimize || process.env.NODE_ENV === 'production'
const isProduction = options.productionMode || minimize || process.env.NODE_ENV === 'production'
const filename = path.basename(resourcePath)
const context = rootContext || process.cwd()
const sourceRoot = path.dirname(path.relative(context, resourcePath))
Expand Down