Switch to uglifyjs-webpack-plugin #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin uses UglifyJS v3 (`uglify-es`) to minify JavaScript. It can be used to minify ES6.
|
Great—thanks for getting this merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This switches to
uglifyjs-webpack-pluginwhich uses UglifyJS v3 (uglify-es) to minify JavaScript.Why is this required
Right now, we use
babel-preset-envwith some browser versions as the target. This dynamic config may break minification because currently the uglify plugin shipped in webpack 3 doesn't support ES6+. For example, if I change mytarget.browsersto["last 2 Chrome versions", "last 2 Firefox versions"]it will break uglify. Since this template is meant to be customised by developers, it would be better to have a more robust method for minification.Also see discussion in #44.
Note: This PR is a clone of vuejs-templates/webpack#1119(merged)