Video 6578 display all camera tracks #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olipyskoty
suggested changes
Sep 7, 2021
| @@ -32,7 +32,8 @@ export const ChatProvider: React.FC = ({ children }) => { | |||
| window.chatClient = client; | |||
| setChatClient(client); | |||
| }) | |||
| .catch(() => { | |||
| .catch(e => { | |||
| console.error(e); | |||
There was a problem hiding this comment.
I think we will need to add another console.error(e) to line 76
olipyskoty
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR addresses an interoperability issue between this app and Twilio's iOS and Android quickstart apps. The issue was that this app was not displaying video tracks because the tracks were not correctly labeled. If the track name did not include 'camera' (all lowercase), then the track would not be displayed. This means that unlabeled tracks, or tracks labeled as 'Camera' (uppercase 'C') would not be displayed.
This PR removes the requirement that video tracks have a name in order to be displayed. Screen share tracks must still contain the word 'screen' in order to be treated as screen share tracks.
Additionally, this PR makes the following changes:
Burndown
Before review
npm testBefore merge