-
Notifications
You must be signed in to change notification settings - Fork 733
Video 4893 show network for main participant #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video 4893 show network for main participant #499
Conversation
@timmydoza I didn't think any unit tests needed to be updated for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think that's it. Just one tiny change request.
display: 'inline-flex', | ||
'& svg': { | ||
marginLeft: '0.3em', | ||
}, | ||
marginRight: '0.4em', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR adds the network quality indicator to the main participant. This is the same network quality indicator that is used by the
<ParticipantInfo />
component. We decided to move the styling to the<NetworkQualityLevel />
in order to remove the empty boxes from the participant thumbnails in P2P rooms.GitHub issue: #490
Screenshots:

Main participant === localParticipant:
Main participant !== localParticipant:

Burndown
Before review
npm test
Before merge