Skip to content

Stop screensharing on disconnect #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 11, 2021
Merged

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Mar 10, 2021

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR stops all tracks (audio, video, and screen share) when the user is disconnected from the room for any reason (network disconnection, or clicking the 'Disconnect' button). Previously, the tracks were only stopped when the user clicked on the Disconnect button.

Resolves #444

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza requested a review from charliesantos March 10, 2021 16:44
@timmydoza timmydoza merged commit bf9ecab into master Mar 11, 2021
@timmydoza timmydoza deleted the stop-screensharing-on-disconnect branch March 11, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'You are sharing your screen' message is shown after reconnection to the room
2 participants